Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keep alive check for teleporting to the Asset Hub #11324

Closed
Zerophase opened this issue Feb 24, 2025 · 7 comments · Fixed by #11332
Closed

Add keep alive check for teleporting to the Asset Hub #11324

Zerophase opened this issue Feb 24, 2025 · 7 comments · Fixed by #11332
Assignees
Labels
Enhancement Improves existing features or performance, making the SDK more robust and efficient. P3 - Low Non-essential improvements or minor fixes. Can be scheduled flexibly as time permits. UX improvement

Comments

@Zerophase
Copy link

I lost 1 dot last night. I think it was from a tip getting paid that pulled my account just under 1 Dot. Would be nice if there was a UI option for teleporting to the Asset Hub that ran a keep alive check.

@ap211unitech
Copy link
Contributor

Can you please share some more information on this like an image or something? Also, if possible please share the extrinsic for that transaction.

@Zerophase
Copy link
Author

Oh sure. Here's the differences between transfer and teleport. Teleport does not have a keep alive check option.

Image

Image

@ap211unitech
Copy link
Contributor

I see, I was having a little difficulty finding the correct component for Teleport. Thanks for clarifying :)

@ap211unitech ap211unitech self-assigned this Feb 25, 2025
@ap211unitech ap211unitech added UX improvement P3 - Low Non-essential improvements or minor fixes. Can be scheduled flexibly as time permits. Enhancement Improves existing features or performance, making the SDK more robust and efficient. labels Feb 25, 2025
@ap211unitech
Copy link
Contributor

In my knowledge, Teleport doesn't have any KeepAlive method similar to balances.transferKeepAlive, so technically, we can't mimic that behavior here.

However, by taking a different approach, it will fetch the maximum teleport amount and ensure the user doesn't exceed it.

Image Image

@ap211unitech ap211unitech linked a pull request Feb 25, 2025 that will close this issue
@Zerophase
Copy link
Author

It's not a big deal while Dot is $5. But, let's say Dot is worth $500 some day, then this is an important feature to have to not lose the source address.

@ap211unitech
Copy link
Contributor

Totally agreed! However, from the UI side, we can only support chain methods if the chain provides them. Feel free to open an issue here to request support for it.

For UI side, we have added a PR to ensure that users cannot submit more than the maximum allowed amount, which prevents reaping accounts.

@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing features or performance, making the SDK more robust and efficient. P3 - Low Non-essential improvements or minor fixes. Can be scheduled flexibly as time permits. UX improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants