Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation for asset id when creating a new asset on AssetHub #10978

Closed
2 of 7 tasks
KarimJedda opened this issue Oct 4, 2024 · 1 comment · Fixed by #11213
Closed
2 of 7 tasks

Validation for asset id when creating a new asset on AssetHub #10978

KarimJedda opened this issue Oct 4, 2024 · 1 comment · Fixed by #11213
Assignees
Labels
Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability. Compatibility Ensures SDK compatibility with ecosystem updates and major dependency changes. P2 - Medium Important but not urgent. Enhances functionality and value, scheduled after higher priorities.

Comments

@KarimJedda
Copy link

When creating a new asset, the assetID field should default to the next possible asset_id

Screenshot from 2024-10-04 12-46-08

  • I'm submitting a ...

    • Bug report
    • Feature request
    • Support request
    • Other
  • What is the current behavior and expected behavior?

The current UI makes it seem that any asset id would work, but after a runtime upgrade it is required that newly created asset id's follow a specific rule: the newly created asset's id should be the next possible id of the last created asset.

In other terms, next_asset_id = previous_asset_id + 1

  • What is the motivation for changing the behavior?

Without this change, users will face this error:

Screenshot from 2024-10-04 12-48-33

  • Please tell us about your environment:

    • Version:

    • Environment:

      • Node.js
      • Browser / Polkadot JS Apps
      • Other (limited support for other environments)
@piggydoughnut piggydoughnut self-assigned this Oct 14, 2024
@piggydoughnut piggydoughnut added the Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability. label Oct 14, 2024
@TarikGul TarikGul added P2 - Medium Important but not urgent. Enhances functionality and value, scheduled after higher priorities. Compatibility Ensures SDK compatibility with ecosystem updates and major dependency changes. labels Oct 30, 2024
@piggydoughnut piggydoughnut removed their assignment Nov 20, 2024
@ap211unitech ap211unitech self-assigned this Jan 17, 2025
@ap211unitech ap211unitech linked a pull request Jan 21, 2025 that will close this issue
2 tasks
@github-project-automation github-project-automation bot moved this from P2 - Medium to Done in Polkadot-js general project board Jan 21, 2025
@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability. Compatibility Ensures SDK compatibility with ecosystem updates and major dependency changes. P2 - Medium Important but not urgent. Enhances functionality and value, scheduled after higher priorities.
Development

Successfully merging a pull request may close this issue.

5 participants