Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy::Proxies undecodable storage on Polkadot #145

Closed
liamaharon opened this issue Jan 17, 2024 · 5 comments
Closed

Proxy::Proxies undecodable storage on Polkadot #145

liamaharon opened this issue Jan 17, 2024 · 5 comments

Comments

@liamaharon
Copy link
Contributor

https://github.com/polkadot-fellows/runtimes/actions/runs/7553599023/job/20564716569?pr=137

Looking into it

@liamaharon liamaharon mentioned this issue Jan 17, 2024
19 tasks
@liamaharon
Copy link
Contributor Author

liamaharon commented Jan 17, 2024

There's just a single problematic proxy, introduced here https://polkadot.subscan.io/extrinsic/300532-3 with key 0x1809d78346727a0ef58c0fa03bafa3231d885dcfb277f185f2d8e62a5f290c854d2d16b4be62d0e00e6de68b13b82479fbe988ab9ecb16bad446b67b993cdd9198cd41c7c6259c49.

My best guess is somehow it's in the old format used prior to paritytech/polkadot-sdk@cf4c744, and somehow the migration introduced at that commit did not apply to this key. I'll confirm tomorrow.

@liamaharon
Copy link
Contributor Author

The above hypothesis is correct.

The proxy was not migrated correctly because the SudoBalances proxy type was removed from the runtime, rendering the proxy undecodable before it was able to be migrated. I am able to decode the proxy on this branch: liamaharon@23c9e98

I have opened a PR to simply remove these proxies from storage, since the account they originate from is an old admin acc, which has also become dormant. Could update the pr to instead properly migrate the proxy to the current format if deemed worth the time, but I doubt it..

@liamaharon
Copy link
Contributor Author

Opened referenda to remove instead of via a migration https://polkadot.polkassembly.io/referenda/440

@liamaharon
Copy link
Contributor Author

Referendum passed and confirmed all state decodes.

@bkontur
Copy link
Contributor

bkontur commented Feb 6, 2024

very cool, also check-migrations for Kusama and Polkadot finally passed:
https://github.com/polkadot-fellows/runtimes/actions/runs/7802169560/job/21278977168?pr=137
https://github.com/polkadot-fellows/runtimes/actions/runs/7802169560/job/21278977603?pr=137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants