Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panels #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Panels #1

wants to merge 2 commits into from

Conversation

waltertamboer
Copy link
Contributor

Please review, would love to hear your feedback.

@waltertamboer waltertamboer self-assigned this Dec 18, 2016
Copy link
Contributor

@jaapio jaapio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes are required. It looks OK overall.

2. A body
3. A footer

The body contains the content of the panel, the header can be used to add an
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please state that header and footer are both optional.


## Requirements

- It must be possible to style the component in any way one likes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a upper-cased must. This improves the readability of the requirements


## Constraints

It is invalid to create an `<span>` with for example the classes `block spread`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs to be removed?


The component will resize according the size of the device' screen. The options
that can be part of the header should be handled separately. On small devices
these options might not be visible correctly but this should be investigated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on the type of options we could add a hamburger like menu? This might work for buttons and dropdown menus.

Copy link
Contributor

@renstah renstah Jan 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is a different pattern, because it has its own behaviour.

@jaapio jaapio requested a review from renstah January 11, 2017 13:46
@waltertamboer waltertamboer changed the title Added the first version of the panel component proposal Panel Component Jan 12, 2017
@jaapio jaapio mentioned this pull request Jan 22, 2017
### How the component will work without color

* The panel header should have a bigger font size than the panel body.
* The panel footer should have a smaller font size than the panel body.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Border of the panel must have a certain amount of contrast contrasting with the background of the webpage. Else the panel will not be a visible panel for someone with colorblindness.


### How the component will enforce any a11y requirements

No additional comments here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could contain a description of the inputs that are inside of the panel.

@waltertamboer waltertamboer changed the title Panel Component Panels Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants