-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panels #1
base: master
Are you sure you want to change the base?
Panels #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes are required. It looks OK overall.
2. A body | ||
3. A footer | ||
|
||
The body contains the content of the panel, the header can be used to add an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please state that header and footer are both optional.
|
||
## Requirements | ||
|
||
- It must be possible to style the component in any way one likes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use a upper-cased must. This improves the readability of the requirements
|
||
## Constraints | ||
|
||
It is invalid to create an `<span>` with for example the classes `block spread`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this needs to be removed?
|
||
The component will resize according the size of the device' screen. The options | ||
that can be part of the header should be handled separately. On small devices | ||
these options might not be visible correctly but this should be investigated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on the type of options we could add a hamburger like menu? This might work for buttons and dropdown menus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is a different pattern, because it has its own behaviour.
### How the component will work without color | ||
|
||
* The panel header should have a bigger font size than the panel body. | ||
* The panel footer should have a smaller font size than the panel body. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Border of the panel must have a certain amount of contrast contrasting with the background of the webpage. Else the panel will not be a visible panel for someone with colorblindness.
|
||
### How the component will enforce any a11y requirements | ||
|
||
No additional comments here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could contain a description of the inputs that are inside of the panel.
Please review, would love to hear your feedback.