Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change supertype of <signed integer type>, UInt64 from Float64 to Int128 #21065

Open
nameexhaustion opened this issue Feb 4, 2025 · 0 comments
Labels
enhancement New feature or an improvement of an existing feature
Milestone

Comments

@nameexhaustion
Copy link
Collaborator

Description

It has historically been upcasted to Float64 as we did not have an Int128 type:

(Int64, UInt64) => Some(Float64), // Follow numpy

For bigidx especially, we currently upcast to Int64 which may cause some data loss in the UInt64 column:

#[cfg(feature = "bigidx")]
(Int64, UInt64) => Some(Int64), // Needed for bigidx

@nameexhaustion nameexhaustion added the enhancement New feature or an improvement of an existing feature label Feb 4, 2025
@nameexhaustion nameexhaustion added this to the 2.0.0 milestone Feb 4, 2025
@nameexhaustion nameexhaustion changed the title Change supertype of Int64, UInt64 from Float64 to Int128 Change supertype of <signed integer type>, UInt64 from Float64 to Int128 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant