Skip to content
This repository has been archived by the owner on Sep 24, 2024. It is now read-only.

Upkeep #14

Closed
wants to merge 8 commits into from
Closed

Upkeep #14

wants to merge 8 commits into from

Conversation

dunkenwg
Copy link

No description provided.

@dunkenwg
Copy link
Author

Two code chunks in the README threw errors because of the classes of the data columns that were being checked. We could change the classes and filter values out of the data before running the checks if you'd prefer

@joethorley
Copy link
Member

joethorley commented Sep 18, 2024

I wonder if this package couldn't be archived. Does anything depend on it?

@dunkenwg
Copy link
Author

It doesn't look like any packages depend on it. Check out this search on GitHub

@dunkenwg dunkenwg requested a review from joethorley September 18, 2024 18:32
@dunkenwg
Copy link
Author

dunkenwg commented Sep 18, 2024

If we're not going to archive this package you should take a look at the tests that I changed. Because of the way NULLs are handled by check_vector(), it was giving different error messages. Also we're getting a bunch of S3 method error_set.character needs @export or @exportS3method tag. when trying to check/document this package.

@joethorley
Copy link
Member

Yes let's wait for @aylapear 's input but I'm thinking we should archive.

@dunkenwg dunkenwg requested a review from aylapear September 18, 2024 19:54
@aylapear
Copy link
Member

I am in favour of archiving it. It isn't even loaded in poispkgs so I doubt anyone is using it and looks like an older version of chk and chktemplate type packages.

@joethorley
Copy link
Member

OK I'm going to archive

@joethorley joethorley closed this Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants