Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Set-PnPSearchSettings -SearchBoxPlaceholderText does not work with Vanity domains #2613

Closed
mikelee1313 opened this issue Dec 6, 2022 · 7 comments · Fixed by #2884
Closed
Labels
bug Something isn't working reproduced Issue reproduced after testing

Comments

@mikelee1313
Copy link

Reporting an Issue or Missing Feature

Set-PnPSearchSettings -SearchBoxPlaceholderText "Text" does not work with Vanity domains. It appears to be appending the "-admin" at the end of the URL. Vanity domains do not conform to this standard.

Expected behavior

Executing" Set-PnPSearchSettings -SearchBoxPlaceholderText 'Text' " should locate the correct Admin URL and does not fail with AADSTS500011 error.

Actual behavior

image

The following dialog appears as it's assuming the "tenant-admin.domain.com" URL convention, however, this is incorrect as our organization uses a vanity URL for the admin center.

image

Steps to reproduce behavior

  1. Connect to SPO with pnp

image

  1. Run Set-PnPSearchSettings -SearchBoxPlaceholderText "Search Here"

What is the version of the Cmdlet module you are running?

1.10.50

image

Which operating system/environment are you running PnP PowerShell on?

  • [ X] Windows
@mikelee1313 mikelee1313 added the bug Something isn't working label Dec 6, 2022
@gautamdsheth
Copy link
Collaborator

When using vanity domains, you need to specify -TenantAdminUrl with the value of your tenant admin site collection in the Connect-PnPOnline cmdlet

Can you try that and then execute this Set-PnPSearchSettings command ?

@mikelee1313
Copy link
Author

I will test this this week and update the bug. Thank you!

@mikelee1313
Copy link
Author

Hello All,

Sorry for the delay. Here is the error even after using the -TenantAdminUrl parameter.

image

@pnp pnp deleted a comment from github-actions bot Mar 10, 2023
@KoenZomers
Copy link
Collaborator

KoenZomers commented Mar 10, 2023

I managed to track it down to an hardcoded -admin definition in PnP Framework: https://github.com/pnp/pnpframework/blob/3d6154e7cf596eb7f7ddcdf8863d5ecf1a25ef24/src/lib/PnP.Framework/AuthenticationManager.cs#L1534 . Trying to see how we can fix this.

@KoenZomers
Copy link
Collaborator

@mikelee1313 Thanks for reporting this issue. It will be fixed once the above two referenced PRs have been merged. Once they are, the next calendar day you can use Update-Module PnP.PowerShell -AllowPrerelease to update to a version that would include the fix.

@gautamdsheth
Copy link
Collaborator

Has been fixed now, will be available via tomorrow's nightly build and the next major version whenever it is going to be released

@mikelee1313
Copy link
Author

Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reproduced Issue reproduced after testing
Projects
None yet
4 participants