Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: convert the codebase to typescript #274

Open
hichemfantar opened this issue Sep 11, 2024 · 5 comments · May be fixed by #286
Open

suggestion: convert the codebase to typescript #274

hichemfantar opened this issue Sep 11, 2024 · 5 comments · May be fixed by #286

Comments

@hichemfantar
Copy link

the advantages of typescript need no introduction so i'm asking if the team is open to convert this repo to typescript in accordance with other pmndrs repos.
i can work on this.

@rosskevin
Copy link

@hichemfantar I think I'm going to just venture down this path. Our process needs some extensions/customizations and I need to move forward, see #284

I may just do this, but I can't commit to maintaining it. Preferably we could commit here, but if not, we can do so elsewhere (and hopefully in the end, merge back here)

@hichemfantar
Copy link
Author

hichemfantar commented Jan 17, 2025

I can def migrate the project to ts but like you said, there doesn't seem to be much movement so i'm worried it might be in vain and i also have a pr that was approved but not merged for some reason #279.
let me know what you plan to do

@rosskevin
Copy link

@hichemfantar I'm just going to move forward with it. I need it, hopefully it comes back home here.

I'll take a shot at merging your PR into mine before I start changing everything.

@rosskevin rosskevin linked a pull request Feb 3, 2025 that will close this issue
@rosskevin
Copy link

I'm moving into my userland domain with generation, and my modifications have been working well, especially the new exposeProps feature. If I don't see movement soon I'll probably start publishing a fork of #286 because I need this available as a package for production needs.

Nonetheless, I hope my PR finds a home here for community involvement. I don't want to try and build a separate community if we don't need to.

@hichemfantar
Copy link
Author

I encourage you to publish a fork and not wait, you can always merge back into this repo when the maintainers approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants