Issue 175 make sync chap 2commits -rebased on master #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is #390 but updated to match the current state of Dave and I decided to create a new PR instead of rebasing the old PR because of the size of the changes. This will allow us to more easily view the changes side-by-side to make sure nothing is lost in the rebase. |
jjhursey
added
Accepted as Stable
jjhursey
requested changes
May 25, 2022
Chap_API_Sharing_Basics.tex
Outdated
| @@ -859,7 +690,7 @@ \subsubsection{Query structure support macros} | |||
|
|
|||
| %%%% | |||
| \littleheader{Static initializer for the query structure} | |||
| \declaremacroProvisional{PMIX_QUERY_STATIC_INIT} | |||
| \declaremacro{PMIX_QUERY_STATIC_INIT} | |||
There was a problem hiding this comment.
Suggested change
| \declaremacro{PMIX_QUERY_STATIC_INIT} | |
| \declaremacroProvisional{PMIX_QUERY_STATIC_INIT} |
jjhursey
force-pushed
the
issue_175_make_sync_chap_2commits_rb
branch
2 times, most recently
from
f58e8cd to
297eec3
Compare
… chapter The new Chap_API_Sharing_Basics.tex is identical to the old Chap_API_Sync_Access chapter except the introduction changed and the synchronization API's are deleted. The Sharing_Basics introduction is very minimal right now, but we have additional changes coming to populate this chapter with an thorough explanation of the get/put routines. Signed-off-by: [email protected]
Separated out into a separate commit to keep git from changing the target of the move. (Easier to see what changed this way) Signed-off-by: [email protected]
- Remove unnecessary and confusing "remote" from data exchange description Signed-off-by: [email protected]
jjhursey
force-pushed
the
issue_175_make_sync_chap_2commits_rb
branch
from
297eec3 to
e363d0b
Compare
jjhursey
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of pr#390. This is the one we actually want to merge, but we need to make sure it is applying the same changes as 390.