Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch. 4->3: Clarify three roles of the interface #230

Closed
wants to merge 7 commits into from

Conversation

jjhursey
Copy link
Member

@jjhursey jjhursey commented Dec 4, 2019

  • Effort to clarify the three roles of consumers of the PMIx interface (clients / servers / tools)
  • Goal is to use the new Chapter 3 as a splitting point to direct those focused on a specific role to those sections of the standard that are most meaningful to them.
  • Part of the implementation agnostic/client separation working group effort
  • Ref Issue Further separate out the PMIx client interface from the CL/host interactions #175

@jjhursey jjhursey added the WorkInProgress Work In Progress label Dec 4, 2019
@jjhursey jjhursey force-pushed the ch-3-rework branch 3 times, most recently from 1edd37d to 5640c08 Compare December 7, 2019 16:55
@jjhursey jjhursey requested a review from dsolt December 7, 2019 16:56
@jjhursey jjhursey marked this pull request as ready for review December 7, 2019 16:56
@jjhursey
Copy link
Member Author

jjhursey commented Dec 7, 2019

I think this is ready for the Working Group to start reviewing.

@jjhursey
Copy link
Member Author

jjhursey commented Dec 7, 2019

Here is a link to the generated PDF that I will try to keep updated with any further changes:

@jjhursey jjhursey added this to the PMIx v5 Standard milestone Feb 11, 2020
@jjhursey jjhursey changed the title Clarify three roles of the interface Ch. 3: Clarify three roles of the interface Mar 3, 2020
@jjhursey jjhursey changed the title Ch. 3: Clarify three roles of the interface Ch. 4->3: Clarify three roles of the interface Mar 3, 2020
@jjhursey
Copy link
Member Author

jjhursey commented Jun 9, 2020

Per Client Separation Working Group Meeting on June 9, 2020:

  • Move the server init/finalize routines to the "Server-specific interfaces" chapter
  • Move the 'new' preamble text to Chapter 1. This defines the three roles in the interface.
  • Move the general information interfaces to a new chapter out of the init/finalize chapter
  • Make the init/finalize chapter a "Client-Specific Interfaces" chapter
    • For now it includes the tool init/finalize routines. But once we get the Tools chapter then we will move those interfaces to the new chapter.
  • Idea is that we will have chapters dedicated to interfaces specific to each of the three roles. Then the rest of the chapters are generally consumable (more or less) by any role. it also provides a specific chapter for folks to jump to if they are only concerned with one of the three roles.

@jjhursey
Copy link
Member Author

Per WG teleconf June 15, 2020

  • Section 1.3.3 (new section) - General note that 'consumer' is misleading in the title, at least in the current form.
    • Change the title to (here are some options - vote with emoji)
      • 👍 "Types of PMIx API Consumers"
      • 😄 "Categories of PMIx Roles"
      • 🎉 "PMIx Roles"
      • 🚀 "PMIx API Role Groupings"
      • 👎 -- back to the drawing board - suggest in comments or in the next meeting
    • Change the first sentence to
      • "The role of a PMIx process in the PMIx universe is grouped into three categories based on how it operates in the PMIx environment namely as a client, server, or tool"
  • New Chapter 3 ("General Information Interfaces) is a bit small
    • Keep it for now to see if other things fit into this category (maybe renaming the chapter)
    • Maybe PMIx_Query should move in here?
  • New Chapter 4 ("Client-Specific Interfaces") is also small since there are not many interfaces exclusive to clients that cannot also be used by tools and servers.
    • That's ok for now, but seems a bit odd.
  • All other chapters are generally "part of the client role" of the interface - meaning that tools and servers can also use them. Should we put a note in each chapter designating the role in which it is intended to be used?

The current version of the document for reference is attached to this comment.
pmix-standard.pdf

jjhursey added 4 commits June 22, 2020 12:37
 - Move the Attributes chapter to the end of the document with the
   intention of adding better references throughout the document.
 - This allows Chpater 3 to be a splitting point in the document
   between the client / server / tool interfaces.

Signed-off-by: Joshua Hursey <[email protected]>
 * RM starts the client, and it is connected to the PMIx server instance
   inside of that RM once it initializes. PMIx does not fork/exec.

Signed-off-by: Joshua Hursey <[email protected]>
@jjhursey
Copy link
Member Author

I updated the title and first sentence of Section 1.3.3 - attached in the current rendering.
pmix-standard.pdf

Signed-off-by: Joshua Hursey <[email protected]>
@jjhursey
Copy link
Member Author

Per teleconf today - Slight adjustment to first sentence wording.
pmix-standard.pdf

@jjhursey
Copy link
Member Author

We might bring in part of this PR into the PMIx v4.0 standard. We can discuss in the next monthly ASC meeting.

@jjhursey
Copy link
Member Author

This PR has grown stale. It tried to do 2 things:

@jjhursey jjhursey closed this Jan 12, 2021
@jjhursey jjhursey deleted the ch-3-rework branch January 12, 2021 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WorkInProgress Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants