Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python Bindings Appendix #180

Merged
merged 7 commits into from
Sep 5, 2019
Merged

Add Python Bindings Appendix #180

merged 7 commits into from
Sep 5, 2019

Conversation

rhc54
Copy link
Member

@rhc54 rhc54 commented Apr 7, 2019

Create the C <-> Python datatype correspondence table.
Provide Python-language definitions for all C-level interfaces.

Fix minor typos in server module function descriptions

Signed-off-by: Ralph Castain [email protected]

@rhc54 rhc54 requested a review from jjhursey April 7, 2019 14:31
@rhc54
Copy link
Member Author

rhc54 commented Apr 7, 2019

@jjhursey See what you think of the table

@jjhursey jjhursey added the WorkInProgress Work In Progress label Apr 11, 2019
@rhc54 rhc54 force-pushed the topic/py branch 2 times, most recently from db9ab54 to 21a7378 Compare August 17, 2019 14:37
Create the C <-> Python datatype correspondence table.
Provide Python-language definitions for all C-level interfaces.

Signed-off-by: Ralph Castain <[email protected]>
@rhc54 rhc54 changed the title Begin construction of the Python Appendix Add Python Bindings Appendix Aug 19, 2019
@rhc54 rhc54 added RFC Request for Comment and removed WorkInProgress Work In Progress labels Aug 19, 2019
@rhc54 rhc54 requested a review from jjhursey August 19, 2019 16:13
@rhc54
Copy link
Member Author

rhc54 commented Aug 19, 2019

@pmrich @dsikich Please take a look

@rhc54 rhc54 added this to the PMIx v4 Standard milestone Aug 19, 2019
@rhc54
Copy link
Member Author

rhc54 commented Aug 19, 2019

Please use emoji reactions ON THIS COMMENT to indicate your position on this proposal.

* You do not need to vote on every proposal
* If you have no opinion, don't vote - that is also useful data
* If you've already commented on this issue, please still vote so
      we know your current thoughts
* Not all proposals solve exactly the same problem, so we may end
      up accepting proposals that appear to have some overlap

This is not a binding majority-rule vote, but it will be a very
significant input into the corresponding ASC decision.

Here are the meanings for the emojis:

* Hooray or Rocket: I support this so strongly that I
      want to be an advocate for it
* Heart: I think this is an ideal solution
* Thumbs up: I'd be happy with this solution
* Confused: I'd rather we not do this, but I can tolerate it
* Thumbs down: I'd be actively unhappy, and may even consider
      other technologies instead

If you want to explain in more detail, feel free to add another
comment, but please also vote on this comment.

Copy link
Member

@jjhursey jjhursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I think an example would be helpful for the datatypes. Maybe a small C vs small Python PMix program that uses types.

Signed-off-by: Ralph Castain <[email protected]>
@rhc54
Copy link
Member Author

rhc54 commented Aug 20, 2019

@jjhursey See example 😄

@jjhursey
Copy link
Member

Thanks. That example helps!

@rhc54 rhc54 mentioned this pull request Aug 23, 2019
16 tasks
Copy link
Contributor

@SteVwonder SteVwonder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that the plan is to only support Python 3 and not support Python 2? If so, several of my inline comments are irrelevant. Either way, it is probably worth noting in the text that the types specified are assumed to be Python 3 types (i.e., 'string' means Python 3's 'str' and not Python 2's str).

@rhc54
Copy link
Member Author

rhc54 commented Aug 28, 2019

I'm assuming that the plan is to only support Python 3 and not support Python 2? If so, several of my inline comments are irrelevant. Either way, it is probably worth noting in the text that the types specified are assumed to be Python 3 types (i.e., 'string' means Python 3's 'str' and not Python 2's str).

Argonne only wants Python 3 support - I’ll note that in the introduction

Signed-off-by: Ralph Castain <[email protected]>

Co-Authored-By: Stephen Herbein <[email protected]>
@rhc54 rhc54 merged commit 7aac4cd into pmix:master Sep 5, 2019
@rhc54 rhc54 deleted the topic/py branch September 5, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Request for Comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants