-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python Bindings Appendix #180
Conversation
@jjhursey See what you think of the table |
db9ab54
to
21a7378
Compare
Create the C <-> Python datatype correspondence table. Provide Python-language definitions for all C-level interfaces. Signed-off-by: Ralph Castain <[email protected]>
Please use emoji reactions ON THIS COMMENT to indicate your position on this proposal.
This is not a binding majority-rule vote, but it will be a very Here are the meanings for the emojis:
If you want to explain in more detail, feel free to add another |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I think an example would be helpful for the datatypes. Maybe a small C vs small Python PMix program that uses types.
Signed-off-by: Ralph Castain <[email protected]>
@jjhursey See example 😄 |
Thanks. That example helps! |
Signed-off-by: Ralph Castain <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming that the plan is to only support Python 3 and not support Python 2? If so, several of my inline comments are irrelevant. Either way, it is probably worth noting in the text that the types specified are assumed to be Python 3 types (i.e., 'string' means Python 3's 'str' and not Python 2's str
).
Argonne only wants Python 3 support - I’ll note that in the introduction |
Signed-off-by: Ralph Castain <[email protected]> Co-Authored-By: Stephen Herbein <[email protected]>
Signed-off-by: Ralph Castain <[email protected]>
Create the C <-> Python datatype correspondence table.
Provide Python-language definitions for all C-level interfaces.
Fix minor typos in server module function descriptions
Signed-off-by: Ralph Castain [email protected]