-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revision exception votes for PRs #18
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating with changes from main repo
progress on PRs even if minor modifications are made Signed-off-by: Kathryn Mohror <[email protected]>
schulzm
reviewed
Sep 4, 2020
Please use emoji reactions ON THIS COMMENT to indicate your position on this proposal.
Here are the meanings for the emojis:
|
Signed-off-by: Kathryn Mohror <[email protected]>
Signed-off-by: Kathryn Mohror <[email protected]>
jjhursey
reviewed
Oct 1, 2020
Co-authored-by: Josh Hursey <[email protected]>
4Q 2020 ASC Meeting - Oct. 1, 2020
|
1Q 2021 ASC Meeting (Feb. 18, 2021)
|
Due to some problems with git on the branch a fresh version of this PR was created in #24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Accepted
ASC second vote passed. Accepted!
Eligible
Eligible for consideration by ASC
First Vote Passed
ASC first vote passed
Proposed
Ready for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the concept of a Revision Exception vote, which will allow forward progress on PRs even if minor modifications are made after the quarterly meeting review period deadline or after first vote. If all eligible voting members of the ASC vote 'yes' on the Revision Exception vote, then the PR may proceed for normal voting including the modifications. If any member votes 'no' then the proposer must either re-read the PR with the modifications or proceed to normal vote without the modifications.