Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [notary] Validate uuid session id inputs #290

Closed
mattes opened this issue Nov 14, 2024 · 2 comments · Fixed by #482
Closed

feat: [notary] Validate uuid session id inputs #290

mattes opened this issue Nov 14, 2024 · 2 comments · Fixed by #482
Assignees
@mattes @piotr-roslaniec
Labels
feature ✨ New feature or request priority medium 🐲 Should probably get done

Comments

@mattes
Copy link
Contributor

mattes commented Nov 14, 2024

web-prover/notary/src/origo.rs

Line 421 in ce110f4

let session_id = query.session_id.clone();

Or make it type UUID instead of String?
@mattes mattes added bug 🐞 Something isn't working feature ✨ New feature or request and removed bug 🐞 Something isn't working labels Nov 14, 2024
@mattes mattes changed the title bug: Validate uuid session id inputs feat: [notary] Validate uuid session id inputs Nov 14, 2024
@0xJepsen 0xJepsen added the priority medium 🐲 Should probably get done label Nov 14, 2024
@mattes mattes self-assigned this Feb 12, 2025
@Autoparallel
Copy link
Contributor

Is this still a problem?

@mattes
Copy link
Contributor Author

mattes commented Feb 17, 2025 •
edited
Loading

yes, we should validate the user's input.

@piotr-roslaniec piotr-roslaniec self-assigned this Feb 18, 2025
@piotr-roslaniec piotr-roslaniec mentioned this issue Feb 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattes mattes

@piotr-roslaniec piotr-roslaniec

Labels
feature ✨ New feature or request priority medium 🐲 Should probably get done
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Validate session_id as UUID pluto/web-prover
4 participants
@mattes @Autoparallel @piotr-roslaniec @0xJepsen