Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(directus): add oidc #641

Merged
merged 4 commits into from
Apr 14, 2023
Merged

feat(directus): add oidc #641

merged 4 commits into from
Apr 14, 2023

Conversation

walkoss
Copy link
Contributor

@walkoss walkoss commented Apr 13, 2023 •
edited
Loading

Summary

  • Add OIDC for Directus

Test Plan

  • Need to merge it to test plural oidc

Checklist

  • No images hosted from dockerhub
  • Are dashboards present to understand the health of the application. There must be at least 1 of these
    • all databases should have dashboards
    • ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
    • you can use plural from-grafana to convert a grafana dashboard found via google to our CRD
  • Are scaling runbooks present
    • all databases must have scaling runbooks
    • you can use the charts in pluralsh/module-library to accelerate this
  • do you need to add config overlays?
    • inputing secrets
    • configuring autoscaling
  • If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
  • All major clouds must be supported
    • Azure
    • AWS
    • GCP

@walkoss walkoss force-pushed the feat/directus branch 4 times, most recently from 604861a to 6660554 Compare April 13, 2023 23:56
michaeljguarino
michaeljguarino reviewed Apr 14, 2023
View reviewed changes
directus/plural/recipes/directus-aws.yaml
@@ -6,6 +6,10 @@ dependencies:
name: aws-k8s
- repo: ingress-nginx
name: ingress-nginx-aws
oidcSettings:
authMethod: POST
uriFormat: https://{domain}/auth/login/plural/callback
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure this will be the callback url?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am sure, but I am not sure about the authMethod parameter though.

@michaeljguarino michaeljguarino merged commit 9bc9599 into pluralsh:main Apr 14, 2023
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljguarino michaeljguarino michaeljguarino approved these changes

@davidspek davidspek Awaiting requested review from davidspek

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@walkoss @plural-bot @michaeljguarino