feat: specify engine in package.json + use in ci #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David van der Spek <[email protected]>
|
Visit the preview URL for this PR (updated for commit 9e27193): https://pluralsh-design--pr297-node-engine-version-uxqjlxue.web.app (expires Tue, 22 Nov 2022 17:30:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 784914c934330f8d0a9fd65c68898b3988262b7d |
|
🎉 This PR is included in version 1.291.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Node version specified in our CI was getting diverged since there was no single source of truth. This PR specifies the node version in the
package.jsonand our CI will read it from there and install the appropriate version. This will also be useful for keeping our CI up to date with our package as Renovate might update the node version.