-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treemap: drilldown is increasing the height of the treemap #5199
Comments
I don't see this as a bug. In fact that was the expected behaviour to leave the space for the
|
So what's happening here isn't actually that the treemap is growing, it's that the "pathbar" starts out empty and the top level appears in the pathbar. The initial position of the top level label is very close to its position in the pathbar so it looks a bit odd, indeed. I'm not sure what a great fix for this would be... |
@archmoj : I'm also not sure if this is a bug, or could be called an enhancement or feature. I have included a new fiddle, with a basic layout, which hides in fact (unintentionally) the pathbar. By doing a drill down, it fills the whole space above, and overlaps with the modebar. @nicolaskruchten : I agree to label that odd. I can investigate how to keep the height of the treemap constant. |
I think I'm getting somewhere. The color of the root is harcoded to rgba(0, 0, 0, 0) in ../sunburst/calc.js
And ../treemap/style.js is forcing further styling
By changing the color of the root node, I get the behavior I was looking for : visual fixed height of the treemap. Are there already similar attributes for other graph types that enforce the color and opacity of a specific node? If so, I can use these in a PR. |
I'm not sure I understand what you're aiming to do with this PR... could you elaborate please? If you set the margins to 0, the pathbar will definitely be out of view, but this is pretty much the intended behaviour. |
Maybe the png file at the link explains it better? screenshots before and after, with & without drilldown (pathBar at the bottom) You can rephrase it like : what is the color in the middle of a donut chart ? (Same for sunburst with a labeled root) My proposal is to make the root color configurable. (now hard coded rgba(0,0,0,0)) |
When doing a drill-down in the treemap, the height of the treemap changes, when going from the highest level to any other level.
> jsfiddle
Changing between other levels keeps the height constant, which gives a better, calmer visible feel.
The text was updated successfully, but these errors were encountered: