-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression of bar plot axis scaling between 1.51.1 and 1.51.2 #4567
Comments
It seems so, at first sight. |
Related: #4522. |
Confirmed: I've Tested the demo with and without the if-statement, and it illustrates the same issue. |
I would like to possibly add another test to lock the behaviour. |
@archmoj |
@brubbel the png behavior is not a regression - going back to v1.51.1 or earlier we see this same behavior that the bars disappear in the png output. We might consider it a bug, but this is a little tricky. Normally for a plot downloaded as an image we disable both rounding positions and But for the default output of the download button - 1:1 scaled raster - it would make sense to carve out an exception and retain the behavior used on interactive plots. |
This issue has been tagged with A community PR for this feature would certainly be welcome, but our experience is deeper features like this are difficult to complete without the Plotly maintainers leading the effort. Sponsorship range: $5k-$10k What Sponsorship includes:
Please include the link to this issue when contacting us to discuss. |
@archmoj
96ef28a#diff-41fd60f1e6a06a5340748d3f4b3754e6R218-R225
This commit broke (my) bar plots which are updated in chunks. Horizontal axis of the bar plot stopped rescaling correctly between 1.51.1 and 1.51.2.
This has been working for years so this should be considered as a regression.
By removing this if statement it starts working again:
plotly.js/src/traces/bar/plot.js
Line 218 in acc9c21
New behaviour:
![image](https://user-images.githubusercontent.com/5667690/74196823-639b9980-4c5e-11ea-9173-ac335274af24.png)
Version <= 1.51.1 (or above if-statement removed in 1.51.2):
![image](https://user-images.githubusercontent.com/5667690/74196943-abbabc00-4c5e-11ea-847f-5d5a69c740f0.png)
If required, I'll try to construct a simple example to reproduce.
The text was updated successfully, but these errors were encountered: