Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AppVeyor for karma/jasmine CI testing on IE11 #431

Closed
etpinard opened this issue Apr 15, 2016 · 4 comments · Fixed by #3285
Closed

Use AppVeyor for karma/jasmine CI testing on IE11 #431

etpinard opened this issue Apr 15, 2016 · 4 comments · Fixed by #3285

Comments

@etpinard
Copy link
Contributor

etpinard commented Apr 15, 2016

... and maybe on MS Edge too, down the road.

I've made some prelim. work on the appveyor branch where karma-ie-launcher is used to boot up IE.

Issues that I've ran into

  • all our tests that use our mouseEvent wrapper are failing (because window.mouseEvent does not work in IE11, see prelim attempt for writing a wrapper here)
  • I had to use npm install --force so that node-sass installs properly run after run. This has the side effect of making our AppVeyor test runs > 10 minutes long. We have to find a better way of caching packages.

Full CI outputs: https://ci.appveyor.com/project/etpinard/plotly-js/build/7

Any help from anyone with access to a Windows machine and/or with AppVeyor expertise would be greatly appreciated.

@mdtusz
Copy link
Contributor

mdtusz commented Apr 15, 2016

Interesting. Why was/is the node-sass installation failing?

We should probably add

cache:
  - %PATH_TO_PLOTLYJS%\node_modules
  - %PATH_TO_PLOTLYJS%\npm-cache

to the appveyor.yml though.

@etpinard
Copy link
Contributor Author

Interesting. Why was/is the node-sass installation failing?

I got some Error: EPERM: operation not permitted off this build. This error apparently has happened to other folks (e.g. here).

@etpinard
Copy link
Contributor Author

etpinard commented Nov 1, 2018

@antoinerg would be interesting in taking this one?

My 3-year old attempt is here -> https://github.com/plotly/plotly.js/tree/appveyor (not sure if it'll be useful though)

cc @nicolaskruchten

@etpinard
Copy link
Contributor Author

etpinard commented Nov 1, 2018

Note, we don't have to run all our jasmine tests there. Most of our pixel-based-assertions will probably fail, getting those up-to-speed for IE will be too much of a pain for little gain. We could either tag a few existing tests with a new @IE tag or add a seperate suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants