-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localizing modeBarButtons? #288
Comments
FWIW, I'm getting around the issues by rewriting the For a real fix, it looks like maybe the simplest solution is to have the |
Also ran into some more localization issues revolving d3 time / number formatting. See also: 2cd341a . Seems like we need a more robust general solution. |
I just sent an email to some of you folks since it looks like you all work at Pedago. |
I investigate and I arrive to the same conclusion than booleanbetrayal. For a real fix, it looks like maybe the simplest solution is to have the modeBarButtons config option support hashes, merging those hashes with the default options when assembling in fillCustomButton or else simply export modebarButtons like Icons. that way we could do something like that : modeBarButtons: [[{ That way we would be free to localize by our own. Is there going to be a fix soon ? |
moved to #856 |
Is there a recommended way of doing this? Note that I don't want to change any functionality of the buttons, just update the
title
values.The text was updated successfully, but these errors were encountered: