Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localizing modeBarButtons? #288

Closed
booleanbetrayal opened this issue Feb 26, 2016 · 5 comments
Closed

Localizing modeBarButtons? #288

booleanbetrayal opened this issue Feb 26, 2016 · 5 comments
Labels
feature something new

Comments

@booleanbetrayal
Copy link
Contributor

Is there a recommended way of doing this? Note that I don't want to change any functionality of the buttons, just update the title values.

@booleanbetrayal
Copy link
Contributor Author

FWIW, I'm getting around the issues by rewriting the data-title attributes on those mode bar links as needed once the plot() promise resolves.

For a real fix, it looks like maybe the simplest solution is to have the modeBarButtons config option support hashes, merging those hashes with the default options when assembling in fillCustomButton?

@booleanbetrayal
Copy link
Contributor Author

Also ran into some more localization issues revolving d3 time / number formatting. See also: 2cd341a . Seems like we need a more robust general solution.

@jackparmer
Copy link
Contributor

I just sent an email to some of you folks since it looks like you all work at Pedago.
Please feel free to fill out this form:
https://plot.ly/products/enterprise/get-in-touch/
If this is blocking your work and you would like to talk more seriously about adding this. Its not in our near-term roadmap otherwise.

@keodime
Copy link

keodime commented Jul 28, 2016

I investigate and I arrive to the same conclusion than booleanbetrayal.

For a real fix, it looks like maybe the simplest solution is to have the modeBarButtons config option support hashes, merging those hashes with the default options when assembling in fillCustomButton

or else simply export modebarButtons like Icons. that way we could do something like that :

modeBarButtons: [[{
name: Plotly.modeBarButtons.toImage.name,
title: 'max was here',
click: Plotly.modeBarButtons.toImage.click,
icon: Plotly.modeBarButtons.toImage.icon
}]]

That way we would be free to localize by our own.

Is there going to be a fix soon ?

@etpinard
Copy link
Contributor

moved to #856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

No branches or pull requests

4 participants