@@ -79,7 +80,7 @@ function UnconnectedErrorContent({error, base}) {
* will need to be displayed in full in this error body
*/}
{typeof error.message !== 'string' ||
- error.message.length < 40 ? null : (
+ error.message.length < MAX_MESSAGE_LENGTH ? null : (
{error.message}
@@ -150,7 +151,7 @@ function UnconnectedErrorContent({error, base}) {
);
}
-/* eslint-enable no-inline-comments, no-magic-numbers */
+/* eslint-enable no-inline-comments */
const errorPropTypes = PropTypes.shape({
message: PropTypes.string,
diff --git a/dash-renderer/src/persistence.js b/dash-renderer/src/persistence.js
index 5d8059214f..ca903ec652 100644
--- a/dash-renderer/src/persistence.js
+++ b/dash-renderer/src/persistence.js
@@ -75,10 +75,9 @@ export const storePrefix = '_dash_persistence.';
function err(e) {
const error = typeof e === 'string' ? new Error(e) : e;
- /* eslint-disable no-console */
// Send this to the console too, so it's still available with debug off
+ /* eslint-disable-next-line no-console */
console.error(e);
- /* eslint-disable no-console */
return createAction('ON_ERROR')({
myID: storePrefix,
diff --git a/dash-renderer/src/reducers/reducer.js b/dash-renderer/src/reducers/reducer.js
index 1123134675..1a82bd1ecc 100644
--- a/dash-renderer/src/reducers/reducer.js
+++ b/dash-renderer/src/reducers/reducer.js
@@ -1,4 +1,3 @@
-'use strict';
import {
concat,
equals,
diff --git a/dash-renderer/src/reducers/utils.js b/dash-renderer/src/reducers/utils.js
index 2dab3b7318..e753389f11 100644
--- a/dash-renderer/src/reducers/utils.js
+++ b/dash-renderer/src/reducers/utils.js
@@ -16,18 +16,12 @@ const hasProps = allPass([is(Object), has('props')]);
export const hasPropsId = allPass([
hasProps,
- compose(
- has('id'),
- prop('props')
- ),
+ compose(has('id'), prop('props')),
]);
export const hasPropsChildren = allPass([
hasProps,
- compose(
- has('children'),
- prop('props')
- ),
+ compose(has('children'), prop('props')),
]);
// crawl a layout object, apply a function on every object
diff --git a/dash-renderer/src/registry.js b/dash-renderer/src/registry.js
index 2517581a1c..35d60e4924 100644
--- a/dash-renderer/src/registry.js
+++ b/dash-renderer/src/registry.js
@@ -1,10 +1,8 @@
-'use strict';
-
export default {
resolve: component => {
const {type, namespace} = component;
- const ns = window[namespace]; /* global window: true */
+ const ns = window[namespace];
if (ns) {
if (ns[type]) {
diff --git a/dash-renderer/src/store.js b/dash-renderer/src/store.js
index f907c70fbe..13b4d43a3f 100644
--- a/dash-renderer/src/store.js
+++ b/dash-renderer/src/store.js
@@ -1,5 +1,3 @@
-/* global module, require */
-
import {createStore, applyMiddleware} from 'redux';
import thunk from 'redux-thunk';
import {createReducer} from './reducers/reducer';
@@ -34,7 +32,7 @@ const initializeStore = reset => {
if (!reset) {
// TODO - Protect this under a debug mode?
- window.store = store; /* global window:true */
+ window.store = store;
}
if (module.hot) {