Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out Dash CI only requirements into requires-ci.txt? #1742

Closed
anders-kiaer opened this issue Sep 3, 2021 · 1 comment · Fixed by #1745
Closed

Split out Dash CI only requirements into requires-ci.txt? #1742

anders-kiaer opened this issue Sep 3, 2021 · 1 comment · Fixed by #1745

Comments

@anders-kiaer
Copy link
Contributor

anders-kiaer commented Sep 3, 2021

Both pip install dash[dev] and pip install dash[testing] are extra public Dash features (respectively for building Dash components, and using the shipped Dash app test utilities).

Looking at requires-dev.txt and requires-testing.txt, there appears to have leaked https://github.com/plotly/dash CI/test suite dependencies into both files (i.e. dependencies not used by the features in dash[dev] and dash[testing]). Latest one introduced is flaky.

Split out Dash CI only dependencies to a new file?

@alexcjohnson
Copy link
Collaborator

Thanks @anders-kiaer - I was just thinking about exactly this last night and you're exactly right. I think internally we haven't been very clear about what these two extras mean but you're correct as to their original intent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants