Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Regression on callbacks using name argument output=Output(...) #1366

Closed
Marc-Andre-Rivet opened this issue Aug 14, 2020 · 0 comments · Fixed by #1375
Closed

[BUG] Regression on callbacks using name argument output=Output(...) #1366

Marc-Andre-Rivet opened this issue Aug 14, 2020 · 0 comments · Fixed by #1375
Assignees
Labels
bug something broken regression this used to work
Milestone

Comments

@Marc-Andre-Rivet
Copy link
Contributor

Marc-Andre-Rivet commented Aug 14, 2020

Caused by #1180

Example DCC failing test: https://github.com/plotly/dash-core-components/blob/dev/tests/test_integration_1.py#L391

Removing (output=) makes it work:

Output(component_id='test-pathname', component_property='children'),

The problematic line seems to be https://github.com/plotly/dash/blob/dev/dash/dependencies.py#L163

Updating to 👇 makes the test pass:

if isinstance(outputs, (list, tuple)) and len(outputs) == 1:

Expected result:

  • DCC tests pass
  • Added test in Dash for named arguments

@alexcjohnson

@Marc-Andre-Rivet Marc-Andre-Rivet added regression this used to work bug something broken labels Aug 14, 2020
@Marc-Andre-Rivet Marc-Andre-Rivet added this to the OSS milestone Aug 14, 2020
@Marc-Andre-Rivet Marc-Andre-Rivet changed the title [BUG] Regression on output=Output(...) callback [BUG] Regression on callbacks using name argument output=Output(...) Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken regression this used to work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants