Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct test for warnings logged in restricted iframes #1100

Open
josegonzalez opened this issue Jan 28, 2020 · 0 comments
Open

Add correct test for warnings logged in restricted iframes #1100

josegonzalez opened this issue Jan 28, 2020 · 0 comments
Labels
bug something broken P3 backlog

Comments

@josegonzalez
Copy link
Contributor

Describe your context
Please provide us your environment so we can easily reproduce the issue.

  • replace the result of pip list | grep dash below
dash                 1.8.0
dash-core-components 1.7.1
dash-html-components 1.0.2
dash-renderer        1.2.3
dash-table           4.6.0
  • if frontend related, tell us your Browser, Version and OS

    • OS: All
    • Browser: All

Describe the bug

With the change in #1080 to allow usage within restricted iframes, we also do a somewhat poor job of checking the type of the warnings logged.

Expected behavior

We should check the exact error string if possible, or at least check for the existence of a specific substring.

@Marc-Andre-Rivet Marc-Andre-Rivet modified the milestone: Dash v1.9 Jan 29, 2020
@gvwilson gvwilson self-assigned this Jul 17, 2024
@gvwilson gvwilson removed their assignment Aug 2, 2024
@gvwilson gvwilson added P3 backlog bug something broken and removed dash-type-maintenance labels Aug 13, 2024
@gvwilson gvwilson changed the title [BUG] Add correct test for warnings logged in restricted iframes Add correct test for warnings logged in restricted iframes Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken P3 backlog
Projects
None yet
Development

No branches or pull requests

3 participants