-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement run_server for setting host and port in Dash.jl #2
Comments
At master:
|
Since we've gone ahead with providing
This would arguably be more consistent with both |
It's not similar. app.layout = .. is setting the property, app.run_server is the method call. Julia doesn't have methods encapsulated with structures, i.e. there are no classes that you are trying to see :) - this is one of the key design elements of this language. In fact, app. layout = ... is a strange solution from Julia's point of view too. It is much more logical to use ' layout!()`
It looks like "let's write Python on Julia". This, of course, is possible, because Julia is much more powerful and flexible than Python, but we have a different task, don't we? |
A similar situation has occurred when using R as well -- the syntax for I think you're correct that we want to avoid providing Julia users an interface that will appear entirely alien to them, even if it means that the syntax is even more distinct from the original implementation than the one R currently provides. If I'm curious if @alexcjohnson or @chriddyp have other thoughts. |
If a Dash user starts using it in Julia, they will need to master Julia anyway. Even if the Dash api is 1 in 1 like in Python, it needs to learn the principles and ideology of Julia in order to work with the data that is used in the dashboard, for example. And if Dash is different from Julia's standards for being like in Python, it will be much more of a hindrance than a help |
Thanks for adding |
In Python, the Flask server is launched via
app.run_server
; R launches the Fiery server in almost identical fashion (replacing the.
with a$
):Dash.jl should have a
run_server
interface that launches the HTTP server, which initially supports the following two parameters:host
= a character string which specifies a valid IPv4 address for the HTTP serverport
= an integer which specifies the port number on which to listen for HTTP trafficWe should remove
make_handler
and move this logic into the Dash.jl internals. We should also move these existing Dash.jl arguments torun_server
:debug
Eventually we will need to support other arguments to
run_server
, but we can discuss that further once these tasks are completed.The text was updated successfully, but these errors were encountered: