Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit width of embedded dashboards by default #2965

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

ukutaht
Copy link
Contributor

@ukutaht ukutaht commented May 24, 2023

Changes

Fixes a bug that was introduced in #2744

Embedded dashboards used to be limited to max-w-screen-lg by default. I changed it to max-w-screen-xl to provide more space for shadows. But I forgot to update the Tailwind safelist which made the class not apply at all in production.

@ukutaht ukutaht requested a review from a team May 24, 2023 11:00
@bundlemon
Copy link

bundlemon bot commented May 24, 2023

BundleMon

Unchanged files (7)
Status Path Size Limits
static/css/app.css
492.34KB -
static/js/dashboard.js
298.88KB -
static/js/app.js
12.13KB -
static/js/embed.host.js
5.58KB -
static/js/embed.content.js
5.06KB -
tracker/js/plausible.js
742B -
static/js/applyTheme.js
314B -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@ukutaht ukutaht merged commit 3b1e010 into master May 24, 2023
@ukutaht ukutaht deleted the fix-width-on-embedded branch May 24, 2023 11:23
@ukutaht ukutaht mentioned this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants