-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework outbound links and file downloads #2208
Conversation
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing this commit-by-commit was a pleasure, good job @RobertJoonas!
The only change I would request is removing the typeof
check and doing it with handlebars instead.
6778e57
to
7d7eb9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
4ca6c57
to
469d741
Compare
Changes
script.file-downloads.outbound-links.js
and clicking an outbound download link, only outbound link click event is sentTests
Changelog
Documentation
Dark mode