Fix existing tests

plausible · Dec 29, 2021 · df5e785 · df5e785
1 parent f34f6c3
commit df5e785
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/lib/plausible_web/controllers/api/external_stats_controller.ex b/lib/plausible_web/controllers/api/external_stats_controller.ex
@@ -89,7 +89,7 @@ defmodule PlausibleWeb.Api.ExternalStatsController do
   defp event_only_property?(_), do: false
 
   @event_metrics ["visitors", "pageviews"]
-  @session_metrics [:visits, :bounce_rate, :visit_duration]
+  @session_metrics ["visits", "bounce_rate", "visit_duration"]
   defp parse_metrics(params, property, query) do
     metrics =
       Map.get(params, "metrics", "visitors")

diff --git a/lib/plausible_web/controllers/api/stats_controller.ex b/lib/plausible_web/controllers/api/stats_controller.ex
@@ -234,7 +234,7 @@ defmodule PlausibleWeb.Api.StatsController do
         |> transform_keys(%{visitors: "conversions"})
         |> to_csv(["name", "conversions", "conversion_rate"])
       else
-        res |> to_csv(["name", :visitors, :bounce_rate, "visit_duration"])
+        res |> to_csv(["name", :visitors, :bounce_rate, :visit_duration])
       end
     else
       json(conn, res)
@@ -265,7 +265,7 @@ defmodule PlausibleWeb.Api.StatsController do
         |> transform_keys(%{visitors: "conversions"})
         |> to_csv(["name", "conversions", "conversion_rate"])
       else
-        res |> to_csv(["name", :visitors, :bounce_rate, "visit_duration"])
+        res |> to_csv(["name", :visitors, :bounce_rate, :visit_duration])
       end
     else
       json(conn, res)
@@ -296,7 +296,7 @@ defmodule PlausibleWeb.Api.StatsController do
         |> transform_keys(%{visitors: "conversions"})
         |> to_csv(["name", "conversions", "conversion_rate"])
       else
-        res |> to_csv(["name", :visitors, :bounce_rate, "visit_duration"])
+        res |> to_csv(["name", :visitors, :bounce_rate, :visit_duration])
       end
     else
       json(conn, res)
@@ -327,7 +327,7 @@ defmodule PlausibleWeb.Api.StatsController do
         |> transform_keys(%{visitors: "conversions"})
         |> to_csv(["name", "conversions", "conversion_rate"])
       else
-        res |> to_csv(["name", :visitors, :bounce_rate, "visit_duration"])
+        res |> to_csv(["name", :visitors, :bounce_rate, :visit_duration])
       end
     else
       json(conn, res)
@@ -436,7 +436,7 @@ defmodule PlausibleWeb.Api.StatsController do
         |> transform_keys(%{"unique_entrances" => "conversions"})
         |> to_csv(["name", "conversions", "conversion_rate"])
       else
-        entry_pages |> to_csv(["name", "unique_entrances", "total_entrances", "visit_duration"])
+        entry_pages |> to_csv(["name", "unique_entrances", "total_entrances", :visit_duration])
       end
     else
       json(conn, entry_pages)

diff --git a/test/plausible_web/controllers/site_controller_test.exs b/test/plausible_web/controllers/site_controller_test.exs
@@ -374,7 +374,7 @@ defmodule PlausibleWeb.SiteControllerTest do
 
     test "deletes associated google auth", %{conn: conn, user: user, site: site} do
       insert(:google_auth, user: user, site: site)
-      conn = delete(conn, "/#{site.domain}/settings/google")
+      conn = delete(conn, "/#{site.domain}/settings/google-search")
 
       refute Repo.exists?(Plausible.Site.GoogleAuth)
       assert redirected_to(conn, 302) == "/#{site.domain}/settings/search-console"