Add referrerpolicy=no-referrer to DDG favicons

Fixes #343

CHANGELOG.md

@@ -8,6 +8,7 @@ All notable changes to this project will be documented in this file.
 
 ### Fixed
 - Fix issue with creating a PostgreSQL database when `?ssl=true` [plausible/analytics#347](https://github.com/plausible/analytics/issues/347)
+- Do no disclose current URL to DuckDuckGo's favicon service [plausible/analytics#343](https://github.com/plausible/analytics/issues/343)
 
 ## [1.0.0] - 2020-10-06
 

assets/js/dashboard/site-switcher.js

@@ -48,7 +48,7 @@ export default class SiteSwitcher extends React.Component {
     const extraClass = domain === this.props.site.domain ? 'font-medium text-gray-900' : 'hover:bg-gray-100 hover:text-gray-900 focus:outline-none focus:bg-gray-100 focus:text-gray-900'
     return (
       <a href={`/${encodeURIComponent(domain)}`} key={domain} className={`block truncate px-4 py-2 text-sm leading-5 text-gray-700 ${extraClass}`}>
-        <img src={`https://icons.duckduckgo.com/ip3/${domain}.ico`} className="inline w-4 mr-2 align-middle" />
+        <img src={`https://icons.duckduckgo.com/ip3/${domain}.ico`} referrerPolicy="no-referrer" className="inline w-4 mr-2 align-middle" />
         <span>{domain}</span>
       </a>
     )
@@ -94,7 +94,7 @@ export default class SiteSwitcher extends React.Component {
       <div className="relative inline-block text-left z-10 mr-8">
         <button onClick={this.toggle.bind(this)} className={`inline-flex items-center text-lg w-full rounded-md py-2 leading-5 font-bold text-gray-700 focus:outline-none transition ease-in-out duration-150 ${hoverClass}`}>
 
-          <img src={`https://icons.duckduckgo.com/ip3/${this.props.site.domain}.ico`} className="inline w-4 mr-2 align-middle" />
+          <img src={`https://icons.duckduckgo.com/ip3/${this.props.site.domain}.ico`} referrerPolicy="no-referrer" className="inline w-4 mr-2 align-middle" />
           {this.props.site.domain}
           {this.renderArrow()}
         </button>

assets/js/dashboard/stats/modals/sources.js

@@ -86,7 +86,7 @@ class SourcesModal extends React.Component {
     return (
       <tr className="text-sm" key={source.name}>
         <td className="p-2">
-          <img src={`https://icons.duckduckgo.com/ip3/${source.url}.ico`} className="h-4 w-4 mr-2 align-middle inline" />
+          <img src={`https://icons.duckduckgo.com/ip3/${source.url}.ico`} referrerPolicy="no-referrer" className="h-4 w-4 mr-2 align-middle inline" />
           <Link className="hover:underline" to={{search: query.toString(), pathname: '/' + encodeURIComponent(this.props.site.domain)}}>{ source.name }</Link>
         </td>
         <td className="p-2 w-32 font-medium" align="right">{numberFormatter(source.count)}</td>

assets/js/dashboard/stats/sources/referrer-list.js

@@ -74,7 +74,7 @@ export default class Referrers extends React.Component {
           <Bar count={referrer.count} all={this.state.referrers} bg="bg-blue-50" />
           <span className="flex px-2 group" style={{marginTop: '-26px'}} >
             <LinkOption className="block truncate" to={{search: query.toString()}} disabled={referrer.name === 'Direct / None'}>
-              <img src={`https://icons.duckduckgo.com/ip3/${referrer.url}.ico`} className="inline h-4 w-4 mr-2 align-middle -mt-px" />
+              <img src={`https://icons.duckduckgo.com/ip3/${referrer.url}.ico`} referrerPolicy="no-referrer" className="inline h-4 w-4 mr-2 align-middle -mt-px" />
               { referrer.name }
             </LinkOption>
             { this.renderExternalLink(referrer) }

assets/js/dashboard/stats/sources/search-terms.js

@@ -40,7 +40,6 @@ export default class SearchTerms extends React.Component {
           <Bar count={term.count} all={this.state.searchTerms} bg="bg-blue-50" />
           <span className="flex px-2" style={{marginTop: '-26px'}} >
             <span className="block truncate">
-              <img src={`https://icons.duckduckgo.com/ip3/${term.url}.ico`} className="inline h-4 w-4 mr-2 align-middle -mt-px" />
               { term.name }
             </span>
           </span>

assets/js/dashboard/stats/sources/source-list.js

@@ -45,7 +45,7 @@ class AllSources extends React.Component {
           <Bar count={referrer.count} all={this.state.referrers} bg="bg-blue-50" />
           <span className="flex px-2" style={{marginTop: '-26px'}} >
             <Link className="block truncate hover:underline" to={{search: query.toString()}}>
-              <img src={`https://icons.duckduckgo.com/ip3/${referrer.url}.ico`} className="inline h-4 w-4 mr-2 align-middle -mt-px" />
+              <img src={`https://icons.duckduckgo.com/ip3/${referrer.url}.ico`} referrerPolicy="no-referrer" className="inline h-4 w-4 mr-2 align-middle -mt-px" />
               { referrer.name }
             </Link>
           </span>