Skip to content

Commit

Permalink
Fix tests for metadata
Browse files Browse the repository at this point in the history
  • Loading branch information
ukutaht committed Oct 30, 2020
1 parent 0b6e645 commit 044da18
Showing 1 changed file with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ defmodule PlausibleWeb.Api.StatsController.ConversionsTest do
conn = get(conn, "/api/stats/#{site.domain}/conversions?period=day&date=2019-01-01")

assert json_response(conn, 200) == [
%{"name" => "Signup", "count" => 3, "total_count" => 3, "meta_keys" => ["variant"]},
%{"name" => "Visit /register", "count" => 2, "total_count" => 2, "meta_keys" => nil}
%{"name" => "Signup", "count" => 3, "total_count" => 3, "prop_names" => ["variant"]},
%{"name" => "Visit /register", "count" => 2, "total_count" => 2, "prop_names" => nil}
]
end
end
Expand All @@ -34,23 +34,23 @@ defmodule PlausibleWeb.Api.StatsController.ConversionsTest do
)

assert json_response(conn, 200) == [
%{"name" => "Signup", "count" => 3, "total_count" => 3, "meta_keys" => ["variant"]}
%{"name" => "Signup", "count" => 3, "total_count" => 3, "prop_names" => ["variant"]}
]
end
end

describe "GET /api/stats/:domain/meta-breakdown/:key" do
describe "GET /api/stats/:domain/property/:key" do
setup [:create_user, :log_in, :create_site]

test "returns metadata breakdown for goal", %{conn: conn, site: site} do
insert(:goal, %{domain: site.domain, event_name: "Signup"})
filters = Jason.encode!(%{goal: "Signup"})
meta_key = "variant"
prop_key = "variant"

conn =
get(
conn,
"/api/stats/#{site.domain}/meta-breakdown/#{meta_key}?period=day&date=2019-01-01&filters=#{filters}"
"/api/stats/#{site.domain}/property/#{prop_key}?period=day&date=2019-01-01&filters=#{filters}"
)

assert json_response(conn, 200) == [
Expand Down

0 comments on commit 044da18

Please sign in to comment.