Fix upload dataset endpoint (#18)

* Fix endpoint to upload file to datasets API

* Debugging test

* Import create_dataset

* Update DATASET_ENDPOINTS

* Update DATASETS_ENDPOINT

* Fix upload datasets

* Remove print

Author: miguelfferraz

jupyterlab_extension/handlers.py

@@ -8,7 +8,7 @@
 from tornado.escape import utf8
 from tornado.httputil import parse_multipart_form_data
 
-from .services import create_dataset_locally
+from .services import create_dataset, create_dataset_locally
 
 
 class RouteHandler(APIHandler):
@@ -30,11 +30,15 @@ def post(self):
         )
         if "file" in self.request.files:
             file = self.request.files["file"][0]
-            response = create_dataset_locally(file=file["body"], filename=file["filename"])
-            if response:
+
+            uploaded_dataset = create_dataset(file=file["body"], filename=file["filename"])
+
+            local_file = create_dataset_locally(
+                file=file["body"], filename=uploaded_dataset["filename"], name=uploaded_dataset["name"])
+            if local_file:
                 self.set_status(200)
                 self.set_header("Content-Type", "application/json")
-                data = json.dumps(response, default=date_default)
+                data = json.dumps(local_file, default=date_default)
                 self.finish(data)
             else:
                 self.set_status(500)

jupyterlab_extension/services.py

@@ -4,8 +4,8 @@
 
 from unicodedata import normalize
 
-DATASETS_ENDPOINT = os.getenv("DATASETS_ENDPOINT", "http://datasets.kubeflow:8080")
-PROJECTS_ENDPOINT = os.getenv("PROJECTS_ENDPOINT", "http://projects.kubeflow:8080")
+DATASETS_ENDPOINT = os.getenv("DATASETS_ENDPOINT", "http://datasets.platiagro:8080")
+PROJECTS_ENDPOINT = os.getenv("PROJECTS_ENDPOINT", "http://projects.platiagro:8080")
 
 
 def update_task(task_id, experiment_notebook=None, deployment_notebook=None) -> dict:
@@ -84,18 +84,18 @@ def generate_name(filename: str, attempt: int = 1, path: str = "/tmp/data") -> s
     return generate_name(filename, attempt + 1)
 
 
-def create_dataset_locally(file: bytes, filename: str = "file", path: str = "/tmp/data"):
+def create_dataset_locally(file: bytes, filename: str = "file", name: str = "file", path: str = "/tmp/data"):
     """Creates a dataset from a CSV and writes locally.
 
     Args:
         file (bytes): file object content.
-        filename (str, optional): file name. Defaults to "file".
+        filename (str, optional): original file name. Defaults to "file".
+        name (str, optional): new file name generated by datasets API. Defaults to "file".
         path (str, optional): path to be writen. Defaults to "/tmp/data".
 
     Raises:
         OSError: When the writing did not succeed.
     """
-    name = generate_name(filename)
 
     try:
         with open(f"{path}/{name}", 'wb') as csv_file: