Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinguish usage of Ping/Pong message #920

Closed
limebell opened this issue Jul 10, 2020 · 0 comments · Fixed by #930
Closed

Distinguish usage of Ping/Pong message #920

limebell opened this issue Jul 10, 2020 · 0 comments · Fixed by #930
Labels
suggestion Suggestion or feature request

Comments

@limebell
Copy link
Member

Currently, Ping/Pong messages are used in two places:

  1. Dial during preloading in Swarm<T>.
  2. Handshake and liveness checking in protocol.

I suggest to make new type of message for second case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
suggestion Suggestion or feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Separate Ping/Pong message limebell/libplanet
1 participant
@limebell