Remove redundant Initialize() on TestUtils

[OnedgeLee]

Context

libplanet/Libplanet.Tests/TestUtils.cs

Lines 429 to 442 in f3d6674

	txs.AddRange(
	validatorSet.Validators.Select(
	validator => Transaction.Create(
	nonce++,
	GenesisProposer,
	null,
	actions: new IAction[]
	{
	new Initialize(
	validatorSet: validatorSet,
	states: ImmutableDictionary.Create<Address, IValue>()),
	}.Select(x => x.PlainValue),
	timestamp: DateTimeOffset.MinValue)));
	txs = txs.OrderBy(tx => tx.Id).ToList();

Action Initialize() updates validator set of IWorld with given parameter validatorSet.
So above code, that iterates validatorSet, is redundant.
(Initialize() only needs to be called once.)

[hpatel292-seneca]

Hi @Atralupus, could you please assign this to me.

[Atralupus]

Hi @Atralupus, could you please assign this to me.

Sure! I just assigned you to this issue.

And we're also running a hackathon right now named Modathon. We'd love for you to check it out 🙏🏻

https://nine-chronicles.dev/event/2024modathon

[hpatel292-seneca]

Hi @Atralupus, in the issue you mentioned about that iterates validatorSet, is redundant. , so you are saying to remove the iterator like this

var txs = transactions?.ToList() ?? new List<Transaction>();
long nonce = 0;
validatorSet = validatorSet ?? ValidatorSet;

// single transaction for the Initialize action, instead of iterating over validators.
txs.Add(
    Transaction.Create(
        nonce++,
        GenesisProposer,
        null,
        actions: new IAction[]
        {
            new Initialize(
                validatorSet: validatorSet,
                states: ImmutableDictionary.Create<Address, IValue>()),
        }.Select(x => x.PlainValue),
        timestamp: DateTimeOffset.MinValue));

[Atralupus]

Hi @Atralupus, in the issue you mentioned about that iterates validatorSet, is redundant. , so you are saying to remove the iterator like this

var txs = transactions?.ToList() ?? new List<Transaction>();
long nonce = 0;
validatorSet = validatorSet ?? ValidatorSet;

// single transaction for the Initialize action, instead of iterating over validators.
txs.Add(
    Transaction.Create(
        nonce++,
        GenesisProposer,
        null,
        actions: new IAction[]
        {
            new Initialize(
                validatorSet: validatorSet,
                states: ImmutableDictionary.Create<Address, IValue>()),
        }.Select(x => x.PlainValue),
        timestamp: DateTimeOffset.MinValue));

Looks great! Please submit a PR, and we’ll review it with the team. Thanks, and happy contributing!