Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Autolinking #299

Closed
Taylor123 opened this issue Jan 6, 2021 · 6 comments
Closed

Android Autolinking #299

Taylor123 opened this issue Jan 6, 2021 · 6 comments
Assignees
Labels
android enhancement New feature or request

Comments

@Taylor123
Copy link
Contributor

Taylor123 commented Jan 6, 2021

The problem

Android auto linking does not currently work.

Environment

Plaid Link React Native 7.0.0-rc2
ReactNative Version 0.63.3
Occurs on Android yes

react-native config output

"react-native-plaid-link-sdk": {
      "root": "app/node_modules/react-native-plaid-link-sdk",
      "name": "react-native-plaid-link-sdk",
      "platforms": {
        "ios": {
          "sourceDir": "app/node_modules/react-native-plaid-link-sdk/ios",
          "folder": "app/node_modules/react-native-plaid-link-sdk",
          "pbxprojPath": "app/node_modules/react-native-plaid-link-sdk/ios/RNLinksdk.xcodeproj/project.pbxproj",
          "podfile": null,
          "podspecPath": "app/node_modules/react-native-plaid-link-sdk/react-native-plaid-link-sdk.podspec",
          "projectPath": "app/node_modules/react-native-plaid-link-sdk/ios/RNLinksdk.xcodeproj",
          "projectName": "RNLinksdk.xcodeproj",
          "libraryFolder": "Libraries",
          "sharedLibraries": [],
          "plist": [],
          "scriptPhases": []
        },
        "android": null
      },
      "assets": [],
      "hooks": {},
      "params": []
    },

Expected Result

android react-native config should not be null

@JeroenMols JeroenMols added the enhancement New feature or request label Jan 11, 2021
@JeroenMols
Copy link
Collaborator

Thank you for requesting this feature!

Looks interesting, we are going to look into adding support for this.

@JeroenMols JeroenMols self-assigned this Jan 11, 2021
@JeroenMols
Copy link
Collaborator

We've managed to get autolinking work when we use ReactPackage, but not when we use TurboReactPackage.

Looking at the react-native-community-cli project it also seems like turbo packages aren't yet supported: react-native-community/cli#356

So I wonder if both are mutually exclusive? 🤔

@Taylor123 do you happen to know if we can support both autolinking and Turbo packages at the same time? Or do we have to choose one or the other?

@Taylor123
Copy link
Contributor Author

I haven't personally used TurboReactPackage, so i'm not entirely sure. I'll be sure to post here if i gain any insight

@JeroenMols
Copy link
Collaborator

I've created a draft proposal that makes autolinking work (at the expense of app startup time). Please chime in with feedback and opinions.

@JeroenMols
Copy link
Collaborator

We've decided to stick to turbo modules for now as faster app initialization outweighs the easier integration (especially on the longer term)

In the future we may decide to revise this or to add auto linking support for Turbo Modules. (when that becomes possible)

@Taylor123
Copy link
Contributor Author

@JeroenMols Makes sense, thanks for taking the time to look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants