-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is our linter preference #3
Comments
It would be nice to get as close to |
I don't think that should be a goal; node's linter settings are often exceedingly unidiomatic for the ecosystem. |
I'm happy to take this on. I don't have a strong preference for linter settings (I personally prefer using Prettier for style enforcement since it stops the majority of style preference arguments in their tracks 😆 ). Would an org-wide shared config be useful here? Or is that impractical given that the same folks won't be working on all the packages? If a shared config doesn't seem like the way to proceed, I'll make a PR copying over the existing non-repo specific configuration from the nodejs/node |
Imo prettier, if used, should only be used via eslint config :-) I think that its an impractical mandate for the reason you mention, but a shared config is a good idea for common patterns. The most common idiom in the ecosystem, by any metric, is the Airbnb config combined with prettier’s config. Is there a reason not to just use those? |
No objections here |
I don't think the |
for https://github.com/pkgjs/support I used eslint with semistandard - https://github.com/pkgjs/support/blob/main/.eslintrc.json |
See: #1 (comment)
The text was updated successfully, but these errors were encountered: