Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is our linter preference #3

Closed
joesepi opened this issue Apr 30, 2021 · 8 comments · Fixed by #15
Closed

What is our linter preference #3

joesepi opened this issue Apr 30, 2021 · 8 comments · Fixed by #15
Labels
question Further information is requested

Comments

@joesepi
Copy link
Collaborator

joesepi commented Apr 30, 2021

See: #1 (comment)

@joesepi
Copy link
Collaborator Author

joesepi commented May 14, 2021

It would be nice to get as close to nodejs/node as possible.

@joesepi
Copy link
Collaborator Author

joesepi commented May 14, 2021

@ljharb
Copy link
Member

ljharb commented May 14, 2021

I don't think that should be a goal; node's linter settings are often exceedingly unidiomatic for the ecosystem.

@kaicataldo
Copy link

I'm happy to take this on. I don't have a strong preference for linter settings (I personally prefer using Prettier for style enforcement since it stops the majority of style preference arguments in their tracks 😆 ). Would an org-wide shared config be useful here? Or is that impractical given that the same folks won't be working on all the packages?

If a shared config doesn't seem like the way to proceed, I'll make a PR copying over the existing non-repo specific configuration from the nodejs/node .eslintrc.js and we can discuss there.

@ljharb
Copy link
Member

ljharb commented May 17, 2021

Imo prettier, if used, should only be used via eslint config :-)

I think that its an impractical mandate for the reason you mention, but a shared config is a good idea for common patterns.

The most common idiom in the ecosystem, by any metric, is the Airbnb config combined with prettier’s config. Is there a reason not to just use those?

@kaicataldo
Copy link

No objections here

@targos
Copy link

targos commented May 17, 2021

I don't think the nodejs/node config should be replicated/copied to other projects. It is a result the history of the project and has a lot of special rules that are there only to avoid big changes to the code base.

@mhdawson
Copy link
Member

@darcyclarke darcyclarke added the question Further information is requested label Oct 27, 2021
@bcoe bcoe closed this as completed in #15 Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants