Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.3.1 - Default condition should be last one #9691

Closed
davidye opened this issue Sep 22, 2023 · 6 comments
Closed

7.3.1 - Default condition should be last one #9691

davidye opened this issue Sep 22, 2023 · 6 comments
Labels
👯‍♀️ Needs Reproduction Very common: basically need an example that reproduces the issue so that it's easier to identify.

Comments

@davidye
Copy link

davidye commented Sep 22, 2023

Current Behavior

Updated to 7.3.1 and getting this compilation error:

./node_modules/@pixi/color/lib/Color.mjs:1:0
Module not found: Default condition should be last one

Expected Behavior

No compilation error

Steps to Reproduce

Seems related to the hotfix?

Environment

  • pixi.js version: e.g. 7.1.0
  • Browser & Version: e.g. Chrome 108
  • OS & Version: e.g. Ubuntu 22.04
  • Running Example: e.g. https://pixiplayground.com/

Possible Solution

No response

Additional Information

No response

@bigtimebuddy
Copy link
Member

How are you getting this error? Can you please provide more information.

@bigtimebuddy bigtimebuddy added the 👯‍♀️ Needs Reproduction Very common: basically need an example that reproduces the issue so that it's easier to identify. label Sep 22, 2023
@Zyie
Copy link
Member

Zyie commented Sep 23, 2023

How are you getting this error? Can you please provide more information.

Seems like this might be a webpack issue

firebase/firebase-js-sdk#7007

I think I just need to move each default to be below types
https://github.com/pixijs/colord/blob/master/package.json#L35

@Zyie
Copy link
Member

Zyie commented Sep 23, 2023

I've published a new version of colord with that change, so reinstalling pixi should fix this as we use "@pixi/colord": "^2.9.4" so i don't think we need a new release

@Zyie
Copy link
Member

Zyie commented Sep 23, 2023

Confirmed by a user in the discord that this is working for them

@davidye You should just be able to uninstall/reinstall pixi, or maybe npm update pixi.js so it grabs the latest dependency

@Zyie Zyie closed this as completed Sep 23, 2023
@MasatoMakino
Copy link

Dear pixi.js community

Regarding package.json of @pixi/colord v2.9.5, the export field of the root directory . seems to be missing from the fix.

https://github.com/pixijs/colord/blob/400a40e956230c802044c916d39463e66edaf70a/package.json#L32-L42

In local, the problem was corrected when rewritten as follows.

  "exports": {
    ".": {
      "import": {
        "types": "./index.d.ts",
        "default": "./index.mjs"
      },
      "require": {
        "types": "./index.d.ts",
        "default": "./index.js"
      }
    },

I hope this helps the pixi.js community.

@Zyie
Copy link
Member

Zyie commented Sep 23, 2023

Dear pixi.js community

Regarding package.json of @pixi/colord v2.9.5, the export field of the root directory . seems to be missing from the fix.

https://github.com/pixijs/colord/blob/400a40e956230c802044c916d39463e66edaf70a/package.json#L32-L42

In local, the problem was corrected when rewritten as follows.

  "exports": {
    ".": {
      "import": {
        "types": "./index.d.ts",
        "default": "./index.mjs"
      },
      "require": {
        "types": "./index.d.ts",
        "default": "./index.js"
      }
    },

I hope this helps the pixi.js community.

Hey @MasatoMakino thanks for this
I must have missed updating this export last night

I've released 2.9.6 with this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👯‍♀️ Needs Reproduction Very common: basically need an example that reproduces the issue so that it's easier to identify.
Projects
None yet
Development

No branches or pull requests

4 participants