#7186: Replace webpack.scripts with Jest #7340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7340 +/- ##
==========================================
+ Coverage 72.09% 72.26% +0.17%
==========================================
Files 1206 1205 -1
Lines 37449 37430 -19
Branches 7019 7015 -4
==========================================
+ Hits 26997 27048 +51
+ Misses 10452 10382 -70 ☔ View full report in Codecov by Sentry. |
| @@ -32,15 +32,15 @@ registerContribBlocks(); | |||
|
|
|||
| Error.stackTraceLimit = Number.POSITIVE_INFINITY; | |||
|
|
|||
| console.log(`version: ${process.env.NPM_PACKAGE_VERSION}`); | |||
| console.log(`version: ${process.env.npm_package_version}`); | |||
There was a problem hiding this comment.
What's causing the capitalization change?
There was a problem hiding this comment.
The webpack config was intentionally changing the ENV. The lowercase ENV is provided by npm run
grahamlangford
approved these changes
Jan 16, 2024
|
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I wanted to see what making this change would entail. It turns out, it was a quick change. As you can see this drops a lot of custom code and a dependency.
Future Work
This PR is intentionally minimal.
We could replace the
expectcall with a full snapshot so that we don't keep track of involuntary registration changes but also the actual changes in bricks (e.g. if a brick is added and one removed, the expectation is successful but wrong)Checklist