Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focal Point Picker: Guidelines Misalignment #198

Closed
georgeolaru opened this issue Aug 17, 2020 · 3 comments
Closed

Focal Point Picker: Guidelines Misalignment #198

georgeolaru opened this issue Aug 17, 2020 · 3 comments
Assignees
Labels
[Block] Hero WordPress 5.6 Issues related to the future version of WordPress
Milestone

Comments

@georgeolaru
Copy link
Member

In the 8.7.1 version of Gutenberg (the latest) I noticed that the guidelines that we added for center alignment are no longer aligned with the center of the pointer.

It might be in conflict with the 9x9 grid that was added recently, which I don't think it adds much value in this case—the focus is on the pointer as a reference point, not on the container boundaries which are constantly changing according to the block or browser size. If it makes things easier to fix, we could take into consideration the option of removing the 9x9 grid.

CleanShot 2020-08-17 at 11 42 48

@georgeolaru georgeolaru added [Block] Hero WordPress 5.6 Issues related to the future version of WordPress labels Aug 17, 2020
@razwan razwan closed this as completed in 28dbd35 Aug 18, 2020
@razwan razwan added this to the 1.5.3 milestone Aug 18, 2020
@georgeolaru
Copy link
Member Author

@razwan did you succeed in finding a solution for both WordPress 5.5 and the latest version of Gutenberg (8.7.1+)?

@razwan
Copy link
Member

razwan commented Aug 19, 2020

Yes, I tested on both WordPress 5.5 and the latest version of Gutenberg. I found one class added to the focal point picker component that was added recently and used that. Hopefully it will stay like that, but I think it's the best we can do right now.
If anything goes south we can ditch the old styling once 5.6 rolls out.

@georgeolaru
Copy link
Member Author

@razwan Got it! Great approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Hero WordPress 5.6 Issues related to the future version of WordPress
Projects
None yet
Development

No branches or pull requests

2 participants