-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup of vestigial Morfessor
, Varembed
, gensim.models.wrapper(s)
references?
#3342
Comments
I also noted that tox.ini got deleted, but some things still reference tox. |
That's right – tox is gone. We – and by we I mean really @mpenkov mostly – have been simplifying the CI & testing pipeline, as well as pruning dependencies. So:
Either way, a further cleanup and de-referencing the purged modules and dependencies will be welcome! |
Looks like the invalid tests in |
I take it you dropped Travis CI too? |
Filed a new pull request to clean up the tox/Morfessor/wrapper
references. I looked more closely and it seems that Travis CI is still
used so I have left that in place. The notebooks stuff is probably best
left to others to do slowly over time, so I didn't look at that.
#3345
…--
bye,
pabs
https://bonedaddy.net/pabs3/
|
Yes, that is mostly correct. That travis build was a contribution from another author. |
Problem description
I noticed that usage of Morfessor has mostly been removed, but there are some vestigial references to it in a few files. I would just submit a pull request for this, but I'm not sure if the files that reference Morfessor (especially as
.travis.yml
) should just get removed or kept and updated. Then I found that other things that reference Morfessor (such asVarembed.ipynb
) also referencegensim.models.wrappers
, which has also been removed.gensim.models.wrappers
(andgensim.models.wrapper
) are referenced mostly in the notebooks and comments, but also in the code of theTestDtmModel
test, which usesDtmModel
, which has also been removed but is also referenced in some places. Then I also found lots of uses of the wordwrapper
(mostly in the notebooks) in various places that seem to be referencing now removed code fromgensim.models.wrappers
.Steps/code/corpus to reproduce
Versions
This is from the gensim develop branch.
The text was updated successfully, but these errors were encountered: