Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Py2.7 support #2811

Closed
2 tasks done
mpenkov opened this issue Apr 27, 2020 · 2 comments · Fixed by #2812
Closed
2 tasks done

Investigate Py2.7 support #2811

mpenkov opened this issue Apr 27, 2020 · 2 comments · Fixed by #2812
Assignees
Labels
impact HIGH Show-stopper for affected users
Milestone

Comments

@mpenkov
Copy link
Collaborator

mpenkov commented Apr 27, 2020

This PR silently removed Py2.7 support as a side-effect. There is no mention of it in the PR description, commit messages or discussion with the reviewers.

I'm the one who made the change, but it was several months ago, and I myself don't remember what the original intention was.

We need Python 2.7 support for the 3.8.3 release, because a significant number of users (not sure how many) still use that version of Python.

@mpenkov mpenkov added the impact HIGH Show-stopper for affected users label Apr 27, 2020
@mpenkov mpenkov added this to the 3.8.3 milestone Apr 27, 2020
@mpenkov mpenkov self-assigned this Apr 27, 2020
@piskvorky
Copy link
Owner

piskvorky commented Apr 27, 2020

My 2 cents: we don't need the whole automated machinery for 3.8.3. Further development will happen in the 4.0 branch without py2 anyway.

We just need to get py2 working, test it, and release it (once), for legacy users. And keep that branch around for potential critical bugfixes in the future (3.8.4…). But no need to introduce complex automation headaches for ourselves.

I guess it depends on how difficult it'll be to put py2.7 back into CI.

Another option: simply revert the "py3.5+ check" from setup.py and run the test suite manually, old-school.

And in case we also want precompiled wheels for py2.7 + 3.8.3, I can build them locally for Linux + Windows 8.1 + OSX El Capitan, as a one-off.

@mpenkov
Copy link
Collaborator Author

mpenkov commented May 1, 2020

This is done, closing.

@mpenkov mpenkov closed this as completed May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact HIGH Show-stopper for affected users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants