-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature request] Open external tabs as child of current tabs #2391
Comments
I agree that such an option may be useful, if TST can detect a tab was opened with the context exactly matching to the story. But sadly it looks not effective for now, because WebExtensions API provides just restricted ability to detect the context of a tab open. The first checkpoint is
The second checkpoint is the session data accessible via
The third checkpoint is the URL. When the tab has the URL
After these filters how the context is narrowed? Sadly there are still many cases:
The option "New tab with same website as the current tab from location bar or from outside Firefox" affects to all of them, when the URL of the tab has an origin same to the active tab. So the option you suggested will affect all these cases when their URL has an origin different from the active tab. Honestly I think this is too wide, and the option virtually means "how open tabs by default". Then relation of tabs may not mean nothing anymore - a parent tab does not mean the originator of its descendants, a descendant tab does not mean related to its ancestors. It is horrible for me, and it looks hard for me to find a target tab from them, harder than the case with completely flat list of tabs... |
Oh wow, thanks for thinking this through! I agree that since firefox does not provide any way to find out if the tab was opened from other application, this would essentially translate to "how to open tabs by default". For completeness, as a compromise since I still I open tabs from outside firefox a lot of time I ended up using open-tabs-next-to-current extension which opens a child always by default(unless I am on last child). |
@prashantkhurana can you close this item for now? Maybe we can revisit if Firefox adds functionality to help this. |
I've realized that there is the fourth checkpoint: it is focus of windows. When all Firefox window lose focus,
Rest cases:
As listed above the case |
Finally I've realized that all new tabs opened while no Firefox window has focus are detectable as "opened from external applications". New tabs via drag and drop from other applications are also treated just as a part of this case. So I've introduced a new option very similar to the one suggested by you with these commits: |
Can't thank you enough for thinking about this feature so much and ultimately adding something that works perfectly. |
Currently there is an option "New tab with same website as the current tab from location bar or from outside firefox". This is a feature request to have a similar option but without the same website requirement.
Usecase : I sometimes open lots of links from slack (which are related to the current work I am doing. I would like them to open in the current tree I am on, which is generally the tree related to the work I am doing.
The text was updated successfully, but these errors were encountered: