From b51b89546822ba6b73d76d13c1ac71ab630c3b5e Mon Sep 17 00:00:00 2001
From: ywqzzy <592838129@qq.com>
Date: Wed, 8 Feb 2023 17:11:52 +0800
Subject: [PATCH] address comments

---
 dbms/src/Functions/LeastGreatest.h | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/dbms/src/Functions/LeastGreatest.h b/dbms/src/Functions/LeastGreatest.h
index 5286c982bae..d0b12354767 100644
--- a/dbms/src/Functions/LeastGreatest.h
+++ b/dbms/src/Functions/LeastGreatest.h
@@ -229,11 +229,10 @@ struct LeastGreatestStringImpl
             }
             else if (res == 0)
             {
-                size_t size = std::max(a_size, b_size);
                 if (a_size > b_size)
-                    res_ref[i] = StringRef(&a_data[0], size);
+                    res_ref[i] = StringRef(&a_data[0], a_size);
                 else
-                    res_ref[i] = StringRef(&b_data[0], size);
+                    res_ref[i] = StringRef(&b_data[0], b_size);
             }
             else
             {
@@ -575,7 +574,7 @@ class FunctionLeastGreatestString : public IFunction
                 block.getByPosition(result).column = std::move(col_str);
                 return;
             }
-        }  
+        }
     }
 
 private: