-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tikv inconsistent warning code and message with tidb #51882
Comments
/assign @yibin87 |
The error code returned from tikv is further checked in tidb: tidb/pkg/parser/terror/terror.go Lines 236 to 258 in 6ed747b
The RFCCode of tikv returned error looks like "tikv:3854". However, in tidb, "expression:3854" exists, while "tikv:3854" doesn't. Thus it is finally converted to tikv unknown error code(1105). One way to quick fix this is to add one more check when tikv error's error code doesn't exist: check expression error code again. But it may lead to new problems:
Thus, we need to go through TiFlash/TiKV's error code to ensure they are all consistent with TiDB. |
/remove-type bug |
/type enhancement |
The text was updated successfully, but these errors were encountered: