Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lightning] no retries when pd timeout #31318

Closed
fubinzh opened this issue Jan 5, 2022 · 1 comment
Closed

[lightning] no retries when pd timeout #31318

fubinzh opened this issue Jan 5, 2022 · 1 comment
Assignees
Labels
component/br This issue is related to BR of TiDB. component/lightning This issue is related to Lightning of TiDB. found/automation Found by automation tests severity/moderate type/bug The issue is confirmed as a bug.

Comments

@fubinzh
Copy link

fubinzh commented Jan 5, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

It is observed that there is no retry when pd timeout

2. What did you expect to see? (Required)

There should be retry mechanism when pd connection timeout during lightning import

3. What did you see instead (Required)

Lightning import fails immediately when PD server timeout

2022/01/05 03:12:47.110 +00:00] [INFO] [restore.go:444] ["the whole procedure start"]
[2022/01/05 03:12:47.111 +00:00] [INFO] [restore.go:748] ["restore all schema start"]
[2022/01/05 03:14:30.165 +00:00] [INFO] [restore.go:767] ["restore all schema completed"] [takeTime=1m43.053950663s] []
[2022/01/05 03:14:42.712 +00:00] [ERROR] [restore.go:462] ["run failed"] [step=2] [error="Error 9001: PD server timeout"]
[2022/01/05 03:14:42.712 +00:00] [ERROR] [restore.go:473] ["the whole procedure failed"] [takeTime=1m55.602514675s] [error="Error 9001: PD server timeout"]
[2022/01/05 03:14:42.713 +00:00] [WARN] [local.go:501] ["remove local db file failed"] [error="unlinkat /tmp/sorted-kv-dir: device or resource busy"]

4. What is your TiDB version? (Required)

/ # /tidb-lightning -V
Release Version: v5.4.0
Git Commit Hash: 974b578
Git Branch: heads/refs/tags/v5.4.0
Go Version: go1.16.4
UTC Build Time: 2022-01-03 10:01:05
Race Enabled: false

@fubinzh fubinzh added type/bug The issue is confirmed as a bug. severity/moderate component/lightning This issue is related to Lightning of TiDB. labels Jan 5, 2022
@fubinzh fubinzh added the found/automation Found by automation tests label Jan 5, 2022
@sleepymole
Copy link
Contributor

Similar to #28223.

@glorv glorv added the component/br This issue is related to BR of TiDB. label Jan 5, 2022
@fubinzh fubinzh changed the title [ightning] no retries when pd timeout [lightning] no retries when pd timeout Jan 7, 2022
@glorv glorv assigned 3pointer and unassigned glorv Jan 14, 2022
@niubell niubell closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/br This issue is related to BR of TiDB. component/lightning This issue is related to Lightning of TiDB. found/automation Found by automation tests severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

5 participants