Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

record whether a statement hit plan cache in slow log #16197

Closed
zz-jason opened this issue Apr 8, 2020 · 3 comments · Fixed by #17088
Closed

record whether a statement hit plan cache in slow log #16197

zz-jason opened this issue Apr 8, 2020 · 3 comments · Fixed by #17088
Assignees
@eurekaka
Labels
epic/plan-cache sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.

Comments

@zz-jason
Copy link
Member

zz-jason commented Apr 8, 2020 •
edited
Loading

Development Task

we may need to record whether a statement hit plan cache in slow log. There are some beneficial:

  1. to identify the slow reason is related to the planner.
  2. if a plan is sub-optimal, we can further figure out whether it's caused by the plan cache.
@zz-jason zz-jason added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner labels Apr 8, 2020
@zz-jason
Copy link
Member Author

zz-jason commented Apr 8, 2020

@eurekaka How do you think?

@zz-jason zz-jason mentioned this issue Apr 8, 2020
Closed
@eurekaka eurekaka self-assigned this May 11, 2020
@eurekaka
Copy link
Contributor

@eurekaka How do you think?

Sounds reasonable.

@eurekaka eurekaka mentioned this issue May 11, 2020
Merged
@sre-bot sre-bot mentioned this issue May 12, 2020
Merged
@eurekaka eurekaka mentioned this issue May 28, 2020
Merged
5 tasks
@qw4990 qw4990 mentioned this issue Jun 1, 2020
Closed
10 tasks
@ChenPeng2013
Copy link
Contributor

verified on
master: v4.0.0-beta.2-547-g94a722e2d
release-4.0: v4.0.0-19-g13522b901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eurekaka eurekaka

Labels
epic/plan-cache sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sessionctx: record if a query hits plan cache in slow log eurekaka/tidb
3 participants
@zz-jason @ChenPeng2013 @eurekaka