Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for Dynamic Configuration Change #13795

Open
30 tasks
rleungx opened this issue Nov 28, 2019 · 0 comments
Open
30 tasks

Tracking issue for Dynamic Configuration Change #13795

rleungx opened this issue Nov 28, 2019 · 0 comments
Labels
feature/accepted This feature request is accepted by product managers type/enhancement The issue or PR belongs to an enhancement. type/feature-request Categorizes issue or PR as related to a new feature.
Milestone

Comments

@rleungx
Copy link
Member

rleungx commented Nov 28, 2019

The PR #13660 proposes a unified way to manage the configuration options of TiDB, TiKV, and PD by storing them in PD and support dynamically change the configuration options by using the same way among the different components which can greatly improve usability.

Note

This issue is a TODO list catalog that is used to clarify the split details of the entire feature. If you are interested in a part, use the following workflow:

  1. Select the module you are interested in.
  2. Create a new issue to claim the relevant work and describe the rough implementation in the new issue.
  3. File a new pull request.

Issues:

  • Protocol Definition

  • Basic Framework

    • PD @rleungx
    • TiKV @NingLin-P
      • Implement protocol of communicate with PD @NingLin-P
      • Implement config update workflow @NingLin-P
      • Support change config of raft store module @NingLin-P
      • Support change config of split checker module @NingLin-P
      • Support change config of coprocessor module
      • Support change config of rocksdb module
      • Support change config of gc worker module @NingLin-P
      • Support change config of lock manager module @NingLin-P
    • TiDB
      • Add system table to manage the changed configuration
      • Replace current way (HTTP) with gRPC to get all cluster configuration (need to finish client first)
      • Implement the new start process
  • Client implementation

  • Improvement

  • Optional

    • Add HTTP API for PD to manage configuration
  • Testing

    • Upgrade tests
    • Client implementation tests

Teachability, Documentation, Adoption, Migration Strategy:

Proposal: #13660

@rleungx rleungx added the type/enhancement The issue or PR belongs to an enhancement. label Nov 28, 2019
@scsldb scsldb added type/feature-request Categorizes issue or PR as related to a new feature. feature/accepted This feature request is accepted by product managers labels Oct 20, 2020
@scsldb scsldb added this to the v4.0.10 milestone Oct 20, 2020
@jebter jebter modified the milestones: v4.0.10, v4.0.11 Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/accepted This feature request is accepted by product managers type/enhancement The issue or PR belongs to an enhancement. type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants