Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the profile result more readable #1401

Closed
XuHuaiyu opened this issue Sep 2, 2022 · 4 comments · Fixed by #1450
Closed

make the profile result more readable #1401

XuHuaiyu opened this issue Sep 2, 2022 · 4 comments · Fixed by #1450

Comments

@XuHuaiyu
Copy link

XuHuaiyu commented Sep 2, 2022

Feature Request

Is your feature request related to a problem? Please describe:
Make the profile result more readable

Describe the feature you'd like:

case ProfilingTypeGoroutine:
url = "/debug/pprof/goroutine?debug=1"
profilingRawDataType = RawDataTypeText
fileExtenstion = "*.txt"
case ProfilingTypeMutex:
url = "/debug/pprof/mutex?debug=1"
profilingRawDataType = RawDataTypeText
fileExtenstion = "*.txt"

I suggest using /debug/pprof/goroutine?debug=2 for the Goroutine, and using /debug/pprof/mutex for the Mutex.
It'll make the profile result more readable
Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@lilyjazz
Copy link
Member

@Hawkson-jee PTAL.

@mornyx
Copy link
Collaborator

mornyx commented Nov 30, 2022

Changing from /goroutine?debug=1 to /goroutine?debug=2 is simple and reasonable, but changing from /mutex?debug=1 to /mutex changes the data format from readable text to binary protobuf, which will make the current front-end interaction unavailable. Could you please explain why you need to remove the debug parameter of /mutex?

@XuHuaiyu
Copy link
Author

XuHuaiyu commented Dec 9, 2022

Actually, I do forget why I mentioned mutex here.
I test fetching mutex with and without debug, I think the behavior in dasbboard is acceptable .

@mornyx
Copy link
Collaborator

mornyx commented Dec 9, 2022

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants