Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: add alert rule for process restart (#2756) #2789

Merged
merged 2 commits into from
Aug 26, 2020
Merged

metrics: add alert rule for process restart (#2756) #2789

merged 2 commits into from
Aug 26, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2756 to release-3.0

Signed-off-by: lucklove [email protected]

What problem does this PR solve?

Add an alert rule for tidb-server restarting

What is changed and how it works?

metrics/alertmanager/pd.rules.yml

Add the prometheus alert rule changes(process_start_time_seconds{job="pd"}[5m]) > 0

Check List

Tests

  • No code

Related changes

  • Need to cherry-pick to the release branch

Release note

Add an alert rule for restart

@ti-srebot ti-srebot mentioned this pull request Aug 18, 2020
Merged
@ti-srebot ti-srebot added require-LGT1 Indicates that the PR requires an LGTM. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick labels Aug 18, 2020
@ti-srebot ti-srebot requested a review from disksing August 18, 2020 10:32
@ti-srebot ti-srebot added this to the v3.0.19 milestone Aug 18, 2020
@ti-srebot
Copy link
Contributor Author

@lucklove please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/pd/invitations

@nolouch
Copy link
Contributor

nolouch commented Aug 19, 2020

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 19, 2020
@nolouch
Copy link
Contributor

nolouch commented Aug 25, 2020

LGTM

@nolouch
Copy link
Contributor

nolouch commented Aug 25, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 25, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

nolouch
nolouch approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nolouch
Copy link
Contributor

nolouch commented Aug 26, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@codecov
Copy link

codecov bot commented Aug 26, 2020 •
edited
Loading

Codecov Report

Merging #2789 into release-3.0 will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.0    #2789      +/-   ##
===============================================
- Coverage        69.83%   69.81%   -0.03%     
===============================================
  Files              171      171              
  Lines            16987    16987              
===============================================
- Hits             11863    11859       -4     
+ Misses            4160     4148      -12     
- Partials           964      980      +16
Impacted Files Coverage Δ
pkg/tempurl/tempurl.go 57.14% <0.00%> (-14.29%) ⬇️
pkg/etcdutil/etcdutil.go 86.04% <0.00%> (-9.31%) ⬇️
server/etcd_kv.go 65.95% <0.00%> (-4.26%) ⬇️
server/leader.go 77.91% <0.00%> (-4.17%) ⬇️
server/core/kv.go 76.08% <0.00%> (-1.45%) ⬇️
client/client.go 71.81% <0.00%> (-1.26%) ⬇️
server/option.go 90.90% <0.00%> (-0.76%) ⬇️
server/cluster.go 82.23% <0.00%> (-0.51%) ⬇️
server/grpc_service.go 59.66% <0.00%> (ø)
server/util.go 72.61% <0.00%> (+1.91%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 713f8f4...f7a0d87. Read the comment docs.

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@lhy1024
Copy link
Contributor

lhy1024 commented Aug 26, 2020

/merge

2 similar comments
@lhy1024
Copy link
Contributor

lhy1024 commented Aug 26, 2020

/merge

@lhy1024
Copy link
Contributor

lhy1024 commented Aug 26, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@lhy1024 lhy1024 merged commit d734247 into tikv:release-3.0 Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@disksing disksing Awaiting requested review from disksing

Assignees

@lucklove lucklove

Labels
require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v3.0.19
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @nolouch @lhy1024 @lucklove