Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: automatically reconnect to TiDB #139

Closed
kolbe opened this issue Sep 7, 2022 · 1 comment · Fixed by #147
Closed

Feature Request: automatically reconnect to TiDB #139

kolbe opened this issue Sep 7, 2022 · 1 comment · Fixed by #147
Assignees
@zyguan

Comments

@kolbe
Copy link

kolbe commented Sep 7, 2022

The benchmark executor should automatically reconnect to TiDB and restart any aborted transactions if the connection to TiDB is broken.

High Availability is a core part of the TiDB value proposition, and any situation involving upgrading or failing over to another AZ/region will require applications to re-establish connections to TiDB, so our benchmarking tools should also support reconnections.
@zyguan zyguan mentioned this issue Oct 9, 2022
Merged
@zyguan
Copy link
Collaborator

zyguan commented Oct 9, 2022

Actually, it will automatically reconnect to TiDB if you run a workload with --ignore-error (except for TPCH and will be fixed by #147).

@dbsid dbsid closed this as completed in #147 Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zyguan zyguan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tpch: check connection before each run iteration zyguan/go-tpc
2 participants
@kolbe @zyguan