From 2d03bd6d353ceabfab580769394143e84b5d4038 Mon Sep 17 00:00:00 2001 From: Breezewish Date: Wed, 1 Jul 2020 12:53:53 +0800 Subject: [PATCH 1/2] Add operator version requirement for telemetry config --- telemetry.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/telemetry.md b/telemetry.md index b923f80a154fa..af50729621515 100644 --- a/telemetry.md +++ b/telemetry.md @@ -146,6 +146,10 @@ Configure `spec.tidb.config.enable-telemetry: false` in `tidb-cluster.yaml` or T See [Deploy TiDB Operator in Kubernetes](https://docs.pingcap.com/tidb-in-kubernetes/stable/deploy-tidb-operator) for details. +> **Note:** +> +> This configration item requires at least TiDB Operator v1.1.2 to take effect. + ### Disable TiDB telemetry for deployed TiDB clusters @@ -255,6 +259,10 @@ Configure `spec.pd.config.dashboard.disable-telemetry: true` in `tidb-cluster.ya See [Deploy TiDB Operator in Kubernetes](https://docs.pingcap.com/tidb-in-kubernetes/stable/deploy-tidb-operator) for details. +> **Note:** +> +> This configration item requires at least TiDB Operator v1.1.2 to take effect. + ### Disable TiUP telemetry From a43e8de523445d0a9e5a6486ae53d503598658b0 Mon Sep 17 00:00:00 2001 From: TomShawn <41534398+TomShawn@users.noreply.github.com> Date: Wed, 1 Jul 2020 13:19:18 +0800 Subject: [PATCH 2/2] Apply suggestions from code review --- telemetry.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/telemetry.md b/telemetry.md index af50729621515..d492a187f1d71 100644 --- a/telemetry.md +++ b/telemetry.md @@ -148,7 +148,7 @@ See [Deploy TiDB Operator in Kubernetes](https://docs.pingcap.com/tidb-in-kubern > **Note:** > -> This configration item requires at least TiDB Operator v1.1.2 to take effect. +> This configuration item requires TiDB Operator v1.1.2 or later to take effect. @@ -261,7 +261,7 @@ See [Deploy TiDB Operator in Kubernetes](https://docs.pingcap.com/tidb-in-kubern > **Note:** > -> This configration item requires at least TiDB Operator v1.1.2 to take effect. +> This configuration item requires TiDB Operator v1.1.2 or later to take effect.