From 3aa89d73aab4f869f65b190faa793ef68249a507 Mon Sep 17 00:00:00 2001 From: Grace Cai Date: Mon, 24 Feb 2025 16:29:25 +0800 Subject: [PATCH 1/5] Add temp.md --- temp.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 temp.md diff --git a/temp.md b/temp.md new file mode 100644 index 0000000000000..af27ff4986a7b --- /dev/null +++ b/temp.md @@ -0,0 +1 @@ +This is a test file. \ No newline at end of file From 14069bd0b0c592925bb1653f96c984aa2a6c7e22 Mon Sep 17 00:00:00 2001 From: Grace Cai Date: Mon, 24 Feb 2025 16:29:30 +0800 Subject: [PATCH 2/5] Delete temp.md --- temp.md | 1 - 1 file changed, 1 deletion(-) delete mode 100644 temp.md diff --git a/temp.md b/temp.md deleted file mode 100644 index af27ff4986a7b..0000000000000 --- a/temp.md +++ /dev/null @@ -1 +0,0 @@ -This is a test file. \ No newline at end of file From 682889f9a0a100b4215d6a7cc3f7a2abce17316e Mon Sep 17 00:00:00 2001 From: qiancai Date: Mon, 24 Feb 2025 16:30:30 +0800 Subject: [PATCH 3/5] Update system-variables.md --- system-variables.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system-variables.md b/system-variables.md index 367429a9c96a8..51ccf297de926 100644 --- a/system-variables.md +++ b/system-variables.md @@ -1705,7 +1705,7 @@ mysql> SELECT job_info FROM mysql.analyze_jobs ORDER BY end_time DESC LIMIT 1; - This variable is used to set the priority of executing the `ADD INDEX` operation in the `re-organize` phase. - You can set the value of this variable to `PRIORITY_LOW`, `PRIORITY_NORMAL` or `PRIORITY_HIGH`. -### tidb_ddl_reorg_max_write_speed New in v7.5.5 and v8.5.0 +### tidb_ddl_reorg_max_write_speed New in v6.5.12, v7.5.5, and v8.5.0 - Scope: GLOBAL - Persists to cluster: Yes From e74f99c83c6caaeaf7e376852c82b9557f02a607 Mon Sep 17 00:00:00 2001 From: qiancai Date: Mon, 24 Feb 2025 16:40:36 +0800 Subject: [PATCH 4/5] fix broken links --- releases/release-7.5.5.md | 2 +- releases/release-8.5.0.md | 2 +- sql-statements/sql-statement-admin-alter-ddl.md | 2 +- system-variable-reference.md | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/releases/release-7.5.5.md b/releases/release-7.5.5.md index 7cd1d3cabc5a8..d372ac42bd61c 100644 --- a/releases/release-7.5.5.md +++ b/releases/release-7.5.5.md @@ -13,7 +13,7 @@ Quick access: [Quick start](https://docs.pingcap.com/tidb/v7.5/quick-start-with- ## Compatibility changes -- Add a new system variable [`tidb_ddl_reorg_max_write_speed`](https://docs.pingcap.com/tidb/v7.5/system-variables#tidb_ddl_reorg_max_write_speed-new-in-v755) to limit the maximum speed of the ingest phase when adding indexes [#57156](https://github.com/pingcap/tidb/issues/57156) @[CbcWestwolf](https://github.com/CbcWestwolf) +- Add a new system variable [`tidb_ddl_reorg_max_write_speed`](https://docs.pingcap.com/tidb/v7.5/system-variables#tidb_ddl_reorg_max_write_speed-new-in-v6512-and-v755) to limit the maximum speed of the ingest phase when adding indexes [#57156](https://github.com/pingcap/tidb/issues/57156) @[CbcWestwolf](https://github.com/CbcWestwolf) - Change the default value of the TiKV configuration item [`raft-client-queue-size`](/tikv-configuration-file.md#raft-client-queue-size) from `8192` to `16384` [#17101](https://github.com/tikv/tikv/issues/17101) @[Connor1996](https://github.com/Connor1996) ## Improvements diff --git a/releases/release-8.5.0.md b/releases/release-8.5.0.md index a3d51cbce6727..c26462b2f5c1d 100644 --- a/releases/release-8.5.0.md +++ b/releases/release-8.5.0.md @@ -228,7 +228,7 @@ Compared with the previous LTS 8.1.0, 8.5.0 includes new features, improvements, | Variable name | Change type | Description | |--------|------------------------------|------| | [`tidb_enable_fast_create_table`](/system-variables.md#tidb_enable_fast_create_table-new-in-v800) | Modified | Changes the default value from `OFF` to `ON` after further tests, meaning that the [accelerated table creation](/accelerated-table-creation.md) feature is enabled by default. | -| [`tidb_ddl_reorg_max_write_speed`](/system-variables.md#tidb_ddl_reorg_max_write_speed-new-in-v755-and-v850) | Newly added | Limits the write bandwidth for each TiKV node and only takes effect when index creation acceleration is enabled (controlled by the [`tidb_ddl_enable_fast_reorg`](/system-variables.md#tidb_ddl_enable_fast_reorg-new-in-v630) variable). For example, setting the variable to `200MiB` limits the maximum write speed to 200 MiB/s. | +| [`tidb_ddl_reorg_max_write_speed`](/system-variables.md#tidb_ddl_reorg_max_write_speed-new-in-v6512-v755-and-v850) | Newly added | Limits the write bandwidth for each TiKV node and only takes effect when index creation acceleration is enabled (controlled by the [`tidb_ddl_enable_fast_reorg`](/system-variables.md#tidb_ddl_enable_fast_reorg-new-in-v630) variable). For example, setting the variable to `200MiB` limits the maximum write speed to 200 MiB/s. | ### Configuration parameters diff --git a/sql-statements/sql-statement-admin-alter-ddl.md b/sql-statements/sql-statement-admin-alter-ddl.md index a3ddf6ebd3cd7..3f8d77eed77b0 100644 --- a/sql-statements/sql-statement-admin-alter-ddl.md +++ b/sql-statements/sql-statement-admin-alter-ddl.md @@ -23,7 +23,7 @@ The following are the supported parameters for different DDL jobs and their corr - `ADD INDEX`: - `THREAD`: the concurrency of the DDL job. The initial value is set by `tidb_ddl_reorg_worker_cnt`. - `BATCH_SIZE`: the batch size. The initial value is set by [`tidb_ddl_reorg_batch_size`](/system-variables.md#tidb_ddl_reorg_batch_size). - - `MAX_WRITE_SPEED`: the maximum bandwidth limit for importing index records into each TiKV. The initial value is set by [`tidb_ddl_reorg_max_write_speed`](/system-variables.md#tidb_ddl_reorg_max_write_speed-new-in-v755-and-v850). + - `MAX_WRITE_SPEED`: the maximum bandwidth limit for importing index records into each TiKV. The initial value is set by [`tidb_ddl_reorg_max_write_speed`](/system-variables.md#tidb_ddl_reorg_max_write_speed-new-in-v6512-v755-and-v850). Currently, the preceding parameters only work for `ADD INDEX` jobs that are submitted and running after [`tidb_enable_dist_task`](/system-variables.md#tidb_enable_dist_task-new-in-v710) is disabled. diff --git a/system-variable-reference.md b/system-variable-reference.md index 00e6eac1ee4c3..e64d96b8072eb 100644 --- a/system-variable-reference.md +++ b/system-variable-reference.md @@ -1206,7 +1206,7 @@ Referenced in: - [ADMIN ALTER DDL JOBS](/sql-statements/sql-statement-admin-alter-ddl.md) - [ADMIN SHOW DDL [JOBS|JOB QUERIES]](/sql-statements/sql-statement-admin-show-ddl.md) -- [System Variables](/system-variables.md#tidb_ddl_reorg_max_write_speed-new-in-v755-and-v850) +- [System Variables](/system-variables.md#tidb_ddl_reorg_max_write_speed-new-in-v6512-v755-and-v850) - [TiDB 8.5.0 Release Notes](/releases/release-8.5.0.md) - [TiDB 7.5.5 Release Notes](/releases/release-7.5.5.md) From 6a7117417f29d259fa1edf299d2121c1e6a66608 Mon Sep 17 00:00:00 2001 From: Grace Cai Date: Tue, 25 Feb 2025 11:14:45 +0800 Subject: [PATCH 5/5] Discard changes to releases/release-7.5.5.md --- releases/release-7.5.5.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/releases/release-7.5.5.md b/releases/release-7.5.5.md index d372ac42bd61c..7cd1d3cabc5a8 100644 --- a/releases/release-7.5.5.md +++ b/releases/release-7.5.5.md @@ -13,7 +13,7 @@ Quick access: [Quick start](https://docs.pingcap.com/tidb/v7.5/quick-start-with- ## Compatibility changes -- Add a new system variable [`tidb_ddl_reorg_max_write_speed`](https://docs.pingcap.com/tidb/v7.5/system-variables#tidb_ddl_reorg_max_write_speed-new-in-v6512-and-v755) to limit the maximum speed of the ingest phase when adding indexes [#57156](https://github.com/pingcap/tidb/issues/57156) @[CbcWestwolf](https://github.com/CbcWestwolf) +- Add a new system variable [`tidb_ddl_reorg_max_write_speed`](https://docs.pingcap.com/tidb/v7.5/system-variables#tidb_ddl_reorg_max_write_speed-new-in-v755) to limit the maximum speed of the ingest phase when adding indexes [#57156](https://github.com/pingcap/tidb/issues/57156) @[CbcWestwolf](https://github.com/CbcWestwolf) - Change the default value of the TiKV configuration item [`raft-client-queue-size`](/tikv-configuration-file.md#raft-client-queue-size) from `8192` to `16384` [#17101](https://github.com/tikv/tikv/issues/17101) @[Connor1996](https://github.com/Connor1996) ## Improvements